Fix performance of home feed regeneration #12084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gargron
force-pushed
the
fix-regeneration-worker-performance
branch
from
d2fb1b4 to
b924c63
Compare
ykzts
reviewed
Oct 6, 2019
ykzts
reviewed
Oct 6, 2019
ykzts
reviewed
Oct 6, 2019
ykzts
approved these changes
Oct 6, 2019
Gargron
force-pushed
the
fix-regeneration-worker-performance
branch
from
b924c63 to
ad0a4cb
Compare
Fetching statuses from all followed accounts at once takes too long within Postgres. Fetching them one by one and merging in Ruby could be a lot less resource-intensive Because the query for dynamically fetching the home timeline is so heavy, we can no longer offer it when the home timeline is missing
Gargron
force-pushed
the
fix-regeneration-worker-performance
branch
from
ad0a4cb to
c4d4d85
Compare
ykzts
approved these changes
Oct 6, 2019
Does this fix #6786 finally for invalid accounts? #6786 (comment) EDIT: Apparently it is now mostly fixed but the back button header disappeared |
Closed
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fetching statuses from all followed accounts at once takes too long within Postgres. Fetching them one by one and merging in Ruby could be a lot less resource-intensive. N+1 queries reduced by preloading a lot of the checks in batches (which helps not only regeneration, but also feed merging).
Because the query for dynamically fetching the home timeline is so heavy, we can no longer offer it when the home timeline is missing. This restores the elephant mascot telling you your home feed is being prepared screen in the web UI.
Related fixes: