Remove audio metadata #12171
Merged
Remove audio metadata #12171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gargron
approved these changes
Oct 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was running into an issue where some specific audio files got stuck in Sidekiq or were just ignored. The one that I have noticed was causing this everywhere I look was this one. Eg: on Mastodon.social the audio file did not federate.
I have found that other audio files with metadata also randomly caused issues and I couldn't find any reason why because on some instances they federated fine and on others, using the same setup, they got stuck forever in Sidekiq.
The way I found to fix it was just to strip the metadata. I don't know if this is something that should be stripped or not for audio files in Mastodon but that was the only way I found to make this not a problem for my setup.