Fallback to Create audience when object has no defined audience #12249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gargron
approved these changes
Nov 30, 2019
|
This looks okay but I do not understand the semantics of having the audience on the activity. So I send the "Create" to one audience but a "Delete" to another?? It makes more sense on "Announce" which, frankly, starts looking more and more like an object rather than activity, but that's what we're working with. |
|
I am not sure why one would send a Create Activity and the corresponding Delete to different audiences, but that's entirely possible, yes. The ActivityPub spec itself only talks about objects having an audience in C2S when they are used as a shorthand for a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11137
I'm not sure of possible side-effects.