Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes featured hashtag setting page erroring out instead of rejecting invalid tags #12436

Merged
merged 4 commits into from
Dec 17, 2019
Merged

Fixes featured hashtag setting page erroring out instead of rejecting invalid tags #12436

merged 4 commits into from
Dec 17, 2019

Conversation

ClearlyClaire
Copy link
Contributor

@ClearlyClaire ClearlyClaire commented Nov 21, 2019 •
edited
Loading

Fixes #12386

This was caused by Tag#find_or_create_by_names raising a validation error because of a create! call, instead of deferring the validation to save as usual.

This PR reverts #11621 and applies #11622 instead, as I think Tag#find_or_create_by_names should behave as find_or_create and such and not call create!.

@ClearlyClaire ClearlyClaire marked this pull request as ready for review November 21, 2019 12:55
@Gargron Gargron merged commit da2143b into mastodon:master Dec 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gargron Gargron Gargron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adding tags incorrectly gives a white screen
2 participants
@ClearlyClaire @Gargron