Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix old migration failing with new status default scope #12493

Merged

Conversation

ClearlyClaire
Copy link
Contributor

No description provided.

@aisk
Copy link

aisk commented Dec 30, 2019

Got the same error, and cherry-picked this PR, looks like it dose not work.

@aisk
Copy link

aisk commented Dec 30, 2019

Sorry, forgot run docker build first, trying.

@aisk
Copy link

aisk commented Dec 30, 2019

@Gargron Hi can we add some special notice for people who is upgrading from older version to v3.0.1 to prevented this issue?

@ClearlyClaire
Copy link
Contributor Author

What error do you get after applying this patch?

@aisk
Copy link

aisk commented Dec 31, 2019

@ThibG Sorry can not access that machine now, but the erorr log should be the same with #12689 . I'll verify it later this day.

@aisk
Copy link

aisk commented Dec 31, 2019

Sorry not familiar with rails, but maybe rails thinks the changes you made in this PR is already migrated and trying to run the next migration with error? @ThibG

@aisk
Copy link

aisk commented Jan 1, 2020

@ThibG Sorry I think I should run the db:rollback and cherry-pick this PR and migate again. Solved, sorry for trouble you, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants