Fix account JSON/RSS not being cacheable due to wrong mime type comparison #13116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`request.format` is not a symbol but a `Mime::Type`, so the condition actually never matched, and a session was created even for those requests, preventing caching.
|
Note that, the cache being broken results in weird and interesting behaviors when fetching an actor from an instance that had caching previously working: given sufficient requests to get puma busy, with the provided configuration, nginx will serve stale actor data with Furthermore, we do not expose things like |
ykzts
approved these changes
Feb 19, 2020
Gargron
changed the title
rtucker
pushed a commit
to vulpineclub/mastodon
that referenced
this pull request
Jan 7, 2021
…rison (mastodon#13116) `request.format` is not a symbol but a `Mime::Type`, so the condition actually never matched, and a session was created even for those requests, preventing caching.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
request.formatis not a symbol but aMime::Type, so the condition actuallynever matched, and a session was created even for those requests, preventing
caching.