Fix uninformative error message when uploading unsupported image files #13540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Attempting to upload image files that the browser is unable to load results in “Oops! An unexpected error occurred.” This commit changes the error handling so that an unprocessable image results in the file being sent anyway, which might cover a few corner cases, and provide a slightly better error message.
ClearlyClaire
force-pushed
the
fixes/resize-image-unsupported-browser
branch
from
aead07a
to
f79c97d
Compare
|
Note that it was discovered by someone trying to upload an HEIC picture (presumably by drag'n'drop, so it wasn't obvious that it wasn't supported). We could accept such files in the backend, ImageMagick would know how to handle them. |
Gargron
approved these changes
Apr 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempting to upload image files that the browser is unable to load results
in “Oops! An unexpected error occurred.”
This commit changes the error handling so that an unprocessable image results
in the file being sent anyway, which might cover a few corner cases, and
provide a slightly better error message.
I'm not sure it's the best way to go about it, as it is very unlikely that such an error would mean the image won't be usable server-side either, but on the plus side, it would also allow us to accept more image types on the backend (since user-uploaded images are processed by imagemagick anyway), and may cover more corner cases in outdated/broken browsers/configs.