Fix some account avatars on public pages having incorrect size #13692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gargron
reviewed
May 10, 2020
| @@ -1357,6 +1353,12 @@ | |||
| } | |||
| } | |||
|
|
|||
| .account__avatar:not([width]) { | |||
There was a problem hiding this comment.
This looks like a hack. What's going on here? If it has a width attribute, wouldn't it be an img tag then?
There was a problem hiding this comment.
it is, but so are the other cases we want that style to apply to. It's just that the only case that use a non-default 36px also set the width and height attributes.
ClearlyClaire
force-pushed
the
fixes/public-pages-avatar-size
branch
from
94da9ff to
261d578
Compare
|
Updated to target public pages only, regardless of |
Gargron
approved these changes
May 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.