Add ability to choose media thumbnail in web UI #14244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gargron
force-pushed
the
feature-choose-cover-art-web-ui
branch
from
275bee0
to
f0f4065
Compare
ClearlyClaire
approved these changes
Jul 7, 2020
|
This is basically an invitation for trolls to put completely unrelated thumbnails on videos. I am not a fan of this. |
|
I don't know, people could already engineer videos with a frame they would want to see as thumbnail. |
|
I did no research but with this change it got a lot easier. |
|
I agree with @ThibG, before this moment Mastodon extracted the first frame as thumbnail for the video. And I, in fact, used this here (the only thing is that I suck at ffmpeg and did not concat correctly, so it uses much more frames, which is visually noticeable). This PR just makes it easier for you to have such thumbnail without modifying the video. |
yi0713
added a commit
to yi0713/mastodon
that referenced
this pull request
Jul 13, 2020
shouo1987
pushed a commit
to CrossGate-Pawoo/mastodon
that referenced
this pull request
Dec 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to do something fancier but can't reach any satisfying results for now. At the end of the day, the most important part is having the function at all, and I suppose it looks nice enough.