Audio player visualization improvements #14281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ClearlyClaire
force-pushed
the
fixes/audio-player-improvements
branch
2 times, most recently
from
df99ac0
to
15f0989
Compare
Gargron
reviewed
Jul 10, 2020
ClearlyClaire
force-pushed
the
fixes/audio-player-improvements
branch
from
15f0989
to
e6d98ce
Compare
Gargron
approved these changes
Jul 10, 2020
abcang
pushed a commit
to abcang/mastodon
that referenced
this pull request
Jul 11, 2020
* Fix audio player ticks position * Split visualizer code into own file to comply with license * Change top-left corner of visualizer always showing peaks, clean up code
shouo1987
pushed a commit
to CrossGate-Pawoo/mastodon
that referenced
this pull request
Dec 7, 2022
* Fix audio player ticks position * Split visualizer code into own file to comply with license * Change top-left corner of visualizer always showing peaks, clean up code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly fixes #14276 (only thing left is visualization being tied to playback volume).
Note that the top-right corner thing makes for more accurate and less confusing visualization, but will make “default” visualization look “flat”.
e.g.
Also moves the MIT code to its own file.