Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change disabled retweet icon #14373

Merged
merged 2 commits into from
Jul 22, 2020
Merged

Conversation

ClearlyClaire
Copy link
Contributor

@ClearlyClaire ClearlyClaire commented Jul 22, 2020

The design is inspired by that of the bell-slash fontawesome icon.

Note: to make this work properly with the “reduce motion in animations” (which had no visible difference between disabled and enabled boost icon, btw; as well as slight alignment issues with both versions of the button), I had to disable the subtle color transition when boosting/unboosting. I guess this could be avoided if significantly refactoring this to use svg:use.

Before

image

After

image

@ClearlyClaire ClearlyClaire changed the title [WiP] Change disabled retweet icon Change disabled retweet icon Jul 22, 2020
@ClearlyClaire ClearlyClaire marked this pull request as ready for review July 22, 2020 17:49
@Gargron Gargron merged commit e93efc0 into mastodon:master Jul 22, 2020
shouo1987 pushed a commit to CrossGate-Pawoo/mastodon that referenced this pull request Dec 7, 2022
* Change disabled retweet icon

* Hide fontawesome version of boost icon in both reduce-motion and no-reduce-motion
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants