Fix mark as read in notifications to be saved immediately #14907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix immediately calls the POST /api/v1/markers API when you press the ✓ button in the notification column header and when AppFocus.
Reason:
Currently, if the home timeline is updated within 30 seconds, debounce will postpone the marker POST, so many users are not doing the marker POST until the WebUI is unloaded.
POST (debounce flash) at the time of unloading often did not work as expected on mobile, and as a result, the marker was not updated. The same phenomenon occurs in Safari on PC.
A workaround to perform the unload is to switch from the WebUI to the user settings and back to the WebUI :-)
This also means that the home timeline marker may not be saved. It may be better to call regularly by throttle instead of debounce so that the state is not lost, but this PR does not deal with it.