-
-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "invite request content" display in user account admin page #15265
Merged
Gargron
merged 4 commits into
mastodon:master
from
mashirozx:pr-branch-display-invite-request
Dec 15, 2020
Merged
Add "invite request content" display in user account admin page #15265
Gargron
merged 4 commits into
mastodon:master
from
mashirozx:pr-branch-display-invite-request
Dec 15, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mashirozx
force-pushed
the
pr-branch-display-invite-request
branch
from
December 2, 2020 14:55
0cb6021
to
21a18f0
Compare
I'm a bit uneasy with keeping around information the user can't delete or change… that being said, it's currently being stored anyway, this PR only makes it so it gets displayed to the admin, so in this regard this PR is fine. |
Yep, since normally admins won't check users' account detail pages frequently, a bit more information will never be too much for these who open these pages ʕ•ٹ•ʔ |
mashirozx
force-pushed
the
pr-branch-display-invite-request
branch
from
December 3, 2020 16:43
21a18f0
to
f2fcc33
Compare
mashirozx
changed the title
Add feature of displaying
Add "invite request content" display in user account admin page
Dec 3, 2020
invite_request_text
in admin's user account page
Gargron
requested changes
Dec 15, 2020
mashirozx
force-pushed
the
pr-branch-display-invite-request
branch
from
December 15, 2020 02:37
f2fcc33
to
9dd6a3c
Compare
Gargron
reviewed
Dec 15, 2020
Gargron
approved these changes
Dec 15, 2020
Gargron
approved these changes
Dec 15, 2020
ClearlyClaire
added a commit
to ClearlyClaire/mastodon
that referenced
this pull request
Dec 18, 2020
For consistency with mastodon#15265
Gargron
pushed a commit
that referenced
this pull request
Dec 18, 2020
For consistency with #15265 Co-authored-by: Claire <claire.github-309c@sitedethib.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #14988