Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing pictureInPicture prop in detailed status container #15309

Merged
merged 1 commit into from
Dec 9, 2020
Merged

Fix missing pictureInPicture prop in detailed status container #15309

merged 1 commit into from
Dec 9, 2020

Conversation

noellabo
Copy link
Contributor

@noellabo noellabo commented Dec 8, 2020

No description provided.

@Gargron
Copy link
Member

Gargron commented Dec 8, 2020

Hm... What did I do in features/status/index.js then..?

@Gargron
Copy link
Member

Gargron commented Dec 8, 2020

Ah, <DetailedStatusContainer> is used only on grid view on public pages. We should probably re-use it inside features/status/index.js too to avoid code duplication...

@noellabo
Copy link
Contributor Author

noellabo commented Dec 8, 2020

features/standalone/hashtag_timeline/index.js
features/standalone/public_timeline/index.js

calls

features/status/containers/detailed_status_container.js

calls

features/status/components/detailed_status.js

On a standalone public page (grid view), the pictureInPicture prop is not defined and an error occurs. This solves it.

@Gargron Gargron merged commit f379a52 into mastodon:master Dec 9, 2020
@noellabo noellabo deleted the fix-missing-PinP-props-in-detailed-status-container branch December 9, 2020 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gargron Gargron Gargron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@noellabo @Gargron