Support clock drift in Omniauth SAML provider #15511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The setting is not well documented by the provider, but allows for clock skew between SP and IDP, see: https://github.com/omniauth/omniauth-saml/blob/master/spec/omniauth/strategies/saml_spec.rb
Gargron
approved these changes
Jan 8, 2021
ClearlyClaire
pushed a commit
to ClearlyClaire/mastodon
that referenced
this pull request
Jan 28, 2022
The setting is not well documented by the provider, but allows for clock skew between SP and IDP, see: https://github.com/omniauth/omniauth-saml/blob/master/spec/omniauth/strategies/saml_spec.rb Co-authored-by: kaiyou <dev@kaiyou.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if the SP and IDP are a couple seconds apart, authentication will fail due to the SAML assertion being either too old, or received too early by the SP. This is a common issue with any signature-based authentication scheme (including X509 certificates, and in our case, SAML). When the issue is very sensitive due to short signature lifetime, the verifier may have some configurable tolerance to avoid suffering from clock skew.
The setting is not well documented by the Omniauth SAML provider, but allows for clock skew between SP and IDP, see:
https://github.com/omniauth/omniauth-saml/blob/master/spec/omniauth/strategies/saml_spec.rb
This PR simply exposes this setting as an environment variable for Mastodon, allowing for Mastodon and the IDP to survive clock skew when using SAML.