Fix compose form behavior in mobile view #15555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gargron
requested changes
Feb 11, 2021
app/javascript/mastodon/features/compose/components/compose_form.js
Outdated
Show resolved
Hide resolved
ClearlyClaire
force-pushed
the
fixes/mobile-compose
branch
from
dec2aa2
to
6bbc7f1
Compare
|
ping @Gargron |
Gargron
approved these changes
Mar 24, 2021
chrisguida
pushed a commit
to Start9Labs/mastodon
that referenced
this pull request
Feb 26, 2022
* Fix ComposeForm being mounted twice in mobile view Fixes mastodon#13094 * Fix compose form focus and pre-selection behavior in mobile view * Split _updateFocusAndSelection out of componentDidUpdate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13094
Until this PR, when writing toots in mobile view, two
ComposeFormcomponents were rendered:/web/statuses/newpathThe auto-focus and auto-selection code was executed on the hidden
ComposeForm(causing a crash in PaleMoon, see #13094) and wasn't executed on the displayedComposeFormcomponent.This PR uses media queries to decide whether to render the compose pane's
ComposeForm, avoiding unnecessary rendering the hidden component and avoiding the PaleMoon crash, and makes it so the auto-selection and auto-focus code gets executed when replying to toots in mobile view.