Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change max. image dimensions to 1920x1080px (1080p) #15690

Merged
merged 2 commits into from
Feb 9, 2021

Conversation

Gargron
Copy link
Member

@Gargron Gargron commented Feb 8, 2021

Somebody e-mailed me and made a good point, the dimensions limit has been the same for years while larger monitors have become the norm, so a small adjustment upwards may be warranted.

@Gargron Gargron merged commit acf1842 into main Feb 9, 2021
@Gargron Gargron deleted the fix-increase-image-dimensions branch February 9, 2021 00:21
@tateisu
Copy link
Contributor

tateisu commented Feb 9, 2021

this size limit is not exposed in API. how the clients detect it ?

@Gargron
Copy link
Member Author

Gargron commented Feb 9, 2021

this size limit is not exposed in API. how the clients detect it ?

This isn't the matrix limit (I believe it's something like 4000x4000px right now) which prevents clients from uploading. This is the target dimensions that original files get resized to if they are larger. So, the client does not need to know. (Unless the client wants to minimize bandwidth usage and server-side work, like the web UI does, but it's not a requirement)

@tateisu
Copy link
Contributor

tateisu commented Feb 9, 2021

WebUI does it and client can't do it because API does not API expose the limit.
What is the reason for restricting clients from doing optimal things without disclosing important information?

@tateisu
Copy link
Contributor

tateisu commented Feb 9, 2021

also, mobile device camera image size often greater than 4096.
image resizing capacities in mobile client is almost mandatory in fact.

chrisguida pushed a commit to Start9Labs/mastodon that referenced this pull request Feb 26, 2022
* Change max. image size to 1920x1080px

* Change it in web UI too
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants