Change multiple mentions with same username to render with domain #15718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gargron
force-pushed
the
feature-expand-same-name-accts
branch
from
1492554
to
d14e6be
Compare
Gargron
force-pushed
the
feature-expand-same-name-accts
branch
from
d14e6be
to
9e28085
Compare
Gargron
force-pushed
the
feature-expand-same-name-accts
branch
from
9e28085
to
b559c66
Compare
ykzts
approved these changes
Apr 10, 2021
|
Honestly I'm not sure about this change, especially with it not behaving very consistently |
It's consistent in posts. It's just in bios that it's not. I thought this was long-desired. |
|
The fact whether the domain is displayed depends of whether other people with the same username are mentioned could be confusing. I'm not sure it was long-desired, I haven't seen the subject being brought up very often. Anyway I guess it should be mostly fine for posts, as occurrences of multiple accounts with the same username would be rather rare, but I'm less sure about profiles, this sounds too verbose. |
chrisguida
pushed a commit
to Start9Labs/mastodon
that referenced
this pull request
Feb 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #15506
Caveat: Doesn't work in bios because of a lack of preloading