use host instead of headers to make Rack happy #15741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"headers" is provided by Rails, Rack can't rely on it
|
Ah good catch. Yes the monkey patch does still work for onion services. |
Gargron
approved these changes
Feb 16, 2021
|
(I should also mention for posterity: this PR also likely fixed a minor bug where secure cookies wouldn't have been sent if the onion service was listening on a port other than 80.) |
dr-bonez
pushed a commit
to Start9Labs/mastodon
that referenced
this pull request
Mar 1, 2021
"headers" is provided by Rails, Rack can't rely on it
chrisguida
pushed a commit
to Start9Labs/mastodon
that referenced
this pull request
Feb 26, 2022
"headers" is provided by Rails, Rack can't rely on it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully fixes #15739.
It looks like
headersis provided by Rails' extension to the request class, and doesn't appear in Rack's.I'm going to submit a patch to Rails (hopefully in the next 24 hours) that uses
hostinstead. I've already confirmed it works for that, I just need to get around to writing tests, then I'll file a PR for Rails and eventually try to upstream it to Rack as well. But I have not tested this patch for Mastodon, and the patches are slightly different.@cohosh: Can you see if this works? I don't have a working masto instance right now.