Fix migration script not being able to run if it fails midway #16312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gargron
requested changes
Jun 2, 2021
db/migrate/20210421121431_add_case_insensitive_btree_index_to_tags.rb
Outdated
Show resolved
Hide resolved
| safety_assured { execute 'CREATE UNIQUE INDEX CONCURRENTLY index_tags_on_name_lower ON tags (lower(name))' } | ||
| rescue ActiveRecord::StatementInvalid | ||
| remove_index :tags, name: 'index_tags_on_name_lower' | ||
| raise |
There was a problem hiding this comment.
Why does this raise a StatementInvalid error but others are raising CorruptionError?
There was a problem hiding this comment.
It's not pointing at the documentation because it's a much older migration which is not handled by the maintenance script. It's very unlikely people run into issues running this migration, but I wanted to add the remove_index to at least ensure the effects of the migration would be reverted if it ran into an issue.
Gargron
approved these changes
Jun 2, 2021
GensouSakuya
pushed a commit
to GensouSakuya/mastodon
that referenced
this pull request
Jun 3, 2021
…on#16312) * Fix migration script not being able to run if it fails midway * Fix old migration script * Fix old migration script * Refactor CorruptionError
ClearlyClaire
added a commit
to ClearlyClaire/mastodon
that referenced
this pull request
Jan 28, 2022
…on#16312) * Fix migration script not being able to run if it fails midway * Fix old migration script * Fix old migration script * Refactor CorruptionError
chrisguida
pushed a commit
to Start9Labs/mastodon
that referenced
this pull request
Feb 26, 2022
…on#16312) * Fix migration script not being able to run if it fails midway * Fix old migration script * Fix old migration script * Refactor CorruptionError
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #16273, similar to #15361
More generally, we should be more careful when writing migration scripts with
disable_ddl_transaction!.