Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] Fix a problem about generating an url of notifications #8758

Merged
merged 1 commit into from
Sep 24, 2018

Conversation

GenbuHase
Copy link
Contributor

Overview

It will be work well by adding base-url as a prefix.

@GenbuHase GenbuHase changed the title [Fix] Fix a problem about generating an url of notifications [Bugfix] Fix a problem about generating an url of notifications Sep 23, 2018
@nightpool
Copy link
Member

not sure i quite follow. Even if we do fix the logic there, why doesn't it currently fall through to window.open on line 186?

@GenbuHase
Copy link
Contributor Author

@nightpool
Using URL constructor, 1st argument must be absolute path without a baseUrl as 2nd argument.

@Gargron Gargron merged commit 8b61683 into mastodon:master Sep 24, 2018
@GenbuHase GenbuHase deleted the fix/service_worker_notifys branch September 24, 2018 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants