Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add check for missing tag param in streaming API #8955

Merged
merged 2 commits into from
Oct 11, 2018
Merged

Add check for missing tag param in streaming API #8955

merged 2 commits into from
Oct 11, 2018

Conversation

Gargron
Copy link
Member

@Gargron Gargron commented Oct 11, 2018

Fixes error:

TypeError: Cannot read property 'toLowerCase' of undefined
at app.get (.../streaming/index.js:493:50)

@Gargron
Add check for missing tag param in streaming API
a5b082c 
Fixes error:

```
TypeError: Cannot read property 'toLowerCase' of undefined
at app.get (.../streaming/index.js:493:50)
```
@Gargron Gargron added bug Something isn't working api REST API, Streaming API, Web Push API labels Oct 11, 2018
@Gargron Gargron merged commit 18e7ef6 into master Oct 11, 2018
@Gargron Gargron deleted the fix-streaming-tag-param branch October 11, 2018 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ykzts ykzts ykzts approved these changes

Assignees
No one assigned
Labels
api REST API, Streaming API, Web Push API bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Gargron @ykzts