Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if port/socket is available before forking in Streaming API #9023

Merged
merged 1 commit into from
Oct 20, 2018

Conversation

Gargron
Copy link
Member

@Gargron Gargron commented Oct 19, 2018

Previously, the server would attempt taking port/socket in worker process, and if it was taken, fail, which made the master process create a new worker. This led to really high CPU usage if the
streaming API was started when the port or socket were not available.

Now, before clustering (forking) into worker processes, a test server is created and then removed to check if it can be done.

Resolve #8978

Previously, the server would attempt taking port/socket in worker
process, and if it was taken, fail, which made the master process
create a new worker. This led to really high CPU usage if the
streaming API was started when the port or socket were not
available.

Now, before clustering (forking) into worker processes, a test
server is created and then removed to check if it can be done.
@Gargron Gargron added the deployment Related to runtime configuration, production setups label Oct 19, 2018
@Gargron Gargron merged commit 369cc5f into master Oct 20, 2018
@Gargron Gargron deleted the feature-streaming-fail-fast branch October 20, 2018 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployment Related to runtime configuration, production setups
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants