Skip to content
This repository was archived by the owner on Mar 4, 2025. It is now read-only.

Commit 04ce2ec

Browse files
authored
Merge branch 'qa-accessibility' into qa-accessibility-2912
2 parents d607e02 + 1e1c882 commit 04ce2ec

20 files changed

+217
-129
lines changed

app/app-config.coffee

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,7 @@ config = (
7272

7373
states['MEMBER_LOGIN'] =
7474
url: '/member?retUrl&handle&password&return_to&client_id&response_type&state&redirect_uri&scope'
75+
title: 'Login'
7576
controller : 'TCLoginController as vm'
7677
template: require('./views/tc/login')()
7778
public: true
@@ -87,6 +88,7 @@ config = (
8788
# message : (optional) A message handed by Identity Service when some error occurs
8889
states['MEMBER_REGISTRATION'] =
8990
url: '/member/registration?retUrl&utm_source&utm_medium&utm_campaign&userJWTToken&auth0Jwt&auth0Refresh&message'
91+
title: 'Register'
9092
params: { 'auth0Data', 'regForm' }
9193
controller : 'TCRegistrationController as vm'
9294
template: require('./views/tc/register.jade')()

app/app-run.coffee

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,8 @@ run = ($log, $rootScope, $state, $urlRouter, $location) ->
99

1010
# hide common footer and banner for connect pages to allow new styled footer for connect
1111
$rootScope.hideCommonFooter = toState.url && toState.url.indexOf('/connect') != -1
12+
# page title
13+
$rootScope.pageTitle = toState.title
1214
path = $location.path()
1315
queryString = ''
1416
referrer = ''

app/index.jade

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
doctype html
2-
html(ng-app='accounts')
2+
html(ng-app='accounts', xmlns='http://www.w3.org/1999/xhtml', lang='en', xml:lang='en')
33
head
44
meta(http-equiv='Content-type', content='text/html; charset=utf-8')
55
meta(http-equiv='X-UA-Compatible', content='IE=edge, chrome=1')
6-
meta(name='viewport', content='width=device-width, initial-scale=1, maximum-scale=1, minimum-scale=1, user-scalable=no')
6+
meta(name='viewport', content='width=device-width, initial-scale=1')
77
base(href='/')
8-
title Login | Topcoder
8+
title(ng-bind="pageTitle ? pageTitle + ' | Topcoder' : 'Topcoder'")
99
style.
1010
.ng-hide {
1111
display: none !important;
@@ -16,7 +16,7 @@ html(ng-app='accounts')
1616
.img
1717
ui-view.view-container
1818

19-
div(ui-view="footer", ng-controller="FooterController as vm", ng-hide="hideCommonFooter")
19+
div(ui-view="footer", ng-controller="FooterController as vm", ng-hide="hideCommonFooter", role="region" aria-label="Footer")
2020
footer.account-footer(tabindex="-1", onkeydown="return false;")
2121
a.privacy-policy(ng-href="https://www.topcoder.com/community/how-it-works/privacy-policy/", target="_blank")
2222
| Privacy Policy

app/styles/connect/connect.scss

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
@import "../tc-ui-variables";
1+
@import "../tc-ui-variables.scss";
22

33
.connect-accounts-container {
44
background: $tc-gray-neutral-light;
@@ -79,8 +79,9 @@
7979
}
8080

8181
a {
82-
color: #006dea;
82+
color: $tc-dark-blue-90;
8383
text-decoration: none;
84+
outline-width: 3px;
8485
}
8586

8687
a:focus{

app/styles/connect/login.scss

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,10 @@
88
flex-direction: column;
99
align-items: center;
1010

11+
span {
12+
text-decoration: underline;
13+
}
14+
1115
hr {
1216
width: 50%;
1317
}

app/styles/directives/toggle-password-with-tips.directive.scss

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
@import 'topcoder/tc-includes';
2+
@import "../tc-ui-variables.scss";
23

34
// Toggle password with password tips directive
45
toggle-password-with-tips {
@@ -20,7 +21,7 @@ toggle-password-with-tips {
2021

2122
.input-btn .input:focus ~ .tc-btn {
2223
color: #FFFFFF;
23-
background: #59A7FF;
24+
background: $tc-dark-blue-90;
2425
}
2526

2627
.input-btn .tc-btn,
@@ -30,7 +31,7 @@ toggle-password-with-tips {
3031
position: absolute;
3132
right: 1px;
3233
top: 1px;
33-
background: #DCDCE0;
34+
background: $tc-gray-60;
3435
border: 0;
3536
height: 38px;
3637
border-radius: 0 3px 3px 0;

app/styles/directives/toggle-password.directive.scss

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
@import 'topcoder/tc-includes';
2+
@import '../tc-ui-variables.scss';
23

34
// Toggle password directive
45
toggle-password {
@@ -30,14 +31,14 @@ toggle-password {
3031
position: absolute;
3132
right: 1px;
3233
top: 1px;
33-
background: #ffffff;
34+
background: $tc-white;
3435
border: 0;
35-
border-left: 1px solid #c3c3c8;
36+
border-left: 1px solid $tc-gray-30;
3637
height: 38px;
3738
border-radius: 0 3px 3px 0;
3839
box-shadow: none;
3940
line-height: inherit;
40-
color: #47474f;
41+
color: $tc-gray-80;
4142
}
4243

4344
button#toggleInputTypeBtn {

app/styles/tc-ui-variables.scss

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ $tc-black : #262628;
2727
$tc-gray-90 : #37373C;
2828
$tc-gray-80 : #47474F;
2929
$tc-gray-70 : #5D5D66;
30-
$tc-gray-60 : #747480;
30+
$tc-gray-60 : #6B6B6B;
3131
$tc-gray-50 : #888894;
3232
$tc-gray-40 : #A3A3AD;
3333
$tc-gray-30 : #C3C3C8;
@@ -36,8 +36,10 @@ $tc-gray-10 : #EDEDF2;
3636
$tc-gray-neutral-dark : #EBEBEB;
3737
$tc-gray-neutral-light : #FAFAFB;
3838
$tc-white : #FFFFFF;
39+
$tc-white-cream : #F6F6F6;
3940

4041
// Accents & Shades
42+
$tc-dark-blue-110 : #006AD7;
4143
$tc-dark-blue : $tc-dark-blue;
4244
$tc-dark-blue-90 : #006AD7;
4345
$tc-dark-blue-70 : #59A7FF;

app/styles/tc-ui.scss

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -93,6 +93,10 @@
9393
font-family: inherit;
9494
font-weight: inherit;
9595
}
96+
97+
.tc-btn.show-password-btn:focus {
98+
outline: 2px solid $tc-dark-blue-70;
99+
}
96100

97101
.tc-btn.loading:enabled, .tc-btn:focus:not(:disabled) {
98102
background: $tc-white;
@@ -356,4 +360,4 @@
356360
font-size: 15px;
357361
line-height: 20px;
358362
}
359-
}
363+
}

app/styles/tc/account.scss

Lines changed: 13 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
@import 'topcoder/tc-includes';
22
@import 'topcoder/tc-forms';
3+
@import '../tc-ui-variables.scss';
34

45
.login-container,
56
.register-container,
@@ -25,7 +26,7 @@
2526
height: 70px;
2627
position: relative;
2728

28-
.logo-link img {
29+
.logo-link img, .ico img {
2930
display: inline-block;
3031
height: 30px;
3132
}
@@ -96,7 +97,7 @@
9697
}
9798
span {
9899
@include font-with-weight('Sofia Pro', 500);
99-
color: #6b6b6b;
100+
color: $tc-gray-60;
100101
cursor: pointer;
101102
font-size: 10px;
102103
line-height: 13px;
@@ -115,7 +116,7 @@
115116
margin-bottom: 40px;
116117
p {
117118
@include font-with-weight;
118-
color: #6b6b6b;
119+
color: $tc-gray-60;
119120
font-size: 13px;
120121
line-height: 22px;
121122
text-transform: uppercase;
@@ -191,6 +192,11 @@
191192
text-transform: uppercase;
192193
a {
193194
display: inline;
195+
color: $tc-dark-blue-90 !important;
196+
text-decoration: underline;
197+
&:focus {
198+
outline: 3px auto $tc-dark-blue-90;
199+
}
194200
}
195201
.redirect {
196202
width: 111px;
@@ -209,8 +215,11 @@
209215
justify-content: center;
210216
background-color: $gray-lighter;
211217
padding: 20px 30px 20px 30px;
218+
a {
219+
text-decoration: underline;
220+
}
212221
.copyright-notice {
213-
color: #6b6b6b;
222+
color: $tc-gray-60;
214223
}
215224
}
216225

app/styles/tc/footer.scss

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,10 @@
3939
.privacy-policy {
4040
@extend .copyright-notice;
4141
margin-right: 1.0em;
42+
43+
&:focus {
44+
color: $tc-dark-blue;
45+
}
4246
}
4347

4448
a.privacy-policy:focus {

app/styles/tc/login.scss

Lines changed: 26 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
@import 'topcoder/tc-includes';
2+
@import "../tc-ui-variables";
23

34
.login-container {
45
form {
@@ -9,13 +10,26 @@
910

1011
p + button {
1112
margin-top: 0;
13+
14+
&:focus {
15+
outline: 3px auto $tc-dark-blue-90;
16+
}
1217
}
1318
}
1419
.form-errors {
1520
p {
1621
margin-bottom: 20px;
1722
}
1823
}
24+
25+
button[type=submit] {
26+
background-color: $tc-dark-blue-110 !important;
27+
}
28+
29+
button[type=submit]:disabled {
30+
background-color: $tc-gray-60 !important;
31+
}
32+
1933
.problem-signin {
2034
@include font-with-weight('Merriweather Sans');
2135
color: #a3a3ae;
@@ -26,9 +40,21 @@
2640
font-size: 12px;
2741
margin-bottom: 25px;
2842
margin-top: 25px;
43+
color: #006DEA;
44+
&:focus {
45+
outline: 3px auto $tc-dark-blue-90;
46+
}
2947
}
3048
}
3149
section.login-options {
50+
a:focus {
51+
outline: 3px auto $tc-dark-blue-90;
52+
.network {
53+
span {
54+
text-decoration: underline;
55+
}
56+
}
57+
}
3258
@media (max-width: 767px) {
3359
margin-bottom: 41px;
3460
}

app/styles/tc/register.scss

Lines changed: 28 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,27 @@
11
@import 'topcoder/tc-includes';
2+
@import '../tc-ui-variables.scss';
23

34
.register-container {
5+
a {
6+
text-decoration: underline;
7+
}
8+
49
form {
510
display: flex;
611
flex-flow: column wrap;
712
justify-content: center;
813
align-items: center;
914
button {
1015
margin-top: 0;
16+
background-color: $tc-dark-blue-90;
17+
&:focus {
18+
outline: 3px solid $tc-dark-blue-70;
19+
}
20+
&.disabled {
21+
background-color: $tc-gray-60 !important;
22+
color: $tc-white-cream;
23+
opacity: 1;
24+
}
1125
}
1226

1327
@media (min-width: 768px) {
@@ -53,8 +67,20 @@
5367
}
5468
}
5569

56-
.login-options .networks .network .ico:focus {
57-
outline: 3px solid #77A1F8;
70+
.login-options .networks .network {
71+
span {
72+
color: #757585;
73+
text-decoration: underline;
74+
}
75+
.ico:focus {
76+
outline: 3px solid #77A1F8;
77+
}
78+
}
79+
}
80+
81+
.join-topcoder {
82+
a {
83+
text-decoration: underline;
5884
}
5985
}
6086

app/styles/tc/reset-password.scss

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
@import 'topcoder/tc-includes';
1+
@import "topcoder/tc-includes";
22
@import "../tc-ui-variables";
33

44
.reset-password-container {
@@ -11,7 +11,7 @@
1111
align-self: center;
1212
margin-top: 0px;
1313

14-
&[type='submit'] {
14+
&[type="submit"] {
1515
margin-top: 20px;
1616
}
1717
}
@@ -21,8 +21,10 @@
2121
margin-bottom: 25px;
2222
margin-top: 25px;
2323
}
24-
.link:focus {
25-
outline: 2px solid $tc-dark-blue-90;
24+
.link {
25+
a:focus {
26+
outline: 2px solid $tc-dark-blue-90;
27+
}
2628
}
2729

2830
.tc-btn:focus {

app/views/directives/toggle-password-with-tips.directive.jade

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,4 +18,4 @@
1818
class="input input-btn {{ vm.hasPasswordError() ? 'error' : ''}}"
1919
required)
2020

21-
<button type="button" id="toggleInputTypeBtn" class="tc-btn tc-btn-sm" ng-click="vm.toggleInputType()">{{ vm.toggleShowLabel }}</button>
21+
<button type="button" id="toggleInputTypeBtn" tabIndex="0" class="tc-btn tc-btn-sm show-password-btn" ng-click="vm.toggleInputType()">{{ vm.toggleShowLabel }}</button>

0 commit comments

Comments
 (0)