Skip to content
This repository was archived by the owner on Mar 4, 2025. It is now read-only.

Commit 0e8a525

Browse files
authored
Merge pull request #874 from appirio-tech/tom-membersub-fix-links
Made changes to preserve members subdomain
2 parents 4d459b5 + 94fe90c commit 0e8a525

File tree

3 files changed

+9
-7
lines changed

3 files changed

+9
-7
lines changed

app/directives/ios-card/ios-card.directive.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ import angular from 'angular'
1313
},
1414
controller: ['$scope', 'CONSTANTS', function($scope, CONSTANTS) {
1515
$scope.DOMAIN = CONSTANTS.domain
16+
$scope.SUBDOMAIN = location.href.search('//members') >= 0 ? 'members' : 'www'
1617
}]
1718
}
1819
})

app/directives/ios-card/ios-card.jade

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,18 +3,18 @@
33

44
header
55
.top
6-
a.name(ng-href="https://www.{{DOMAIN}}/challenge-details/{{challenge.id}}/?type={{challenge.track}}") #[span {{challenge.name}}]
6+
a.name(ng-href="https://{{SUBDOMAIN}}.{{DOMAIN}}/challenge-details/{{challenge.id}}/?type={{challenge.track}}") #[span {{challenge.name}}]
77

88
p.subtrack-color {{challenge.subTrack | underscoreStrip}}
99

1010
.challenge-links
1111
.stats
12-
a.registrants(ng-href="https://www.{{DOMAIN}}/challenge-details/{{challenge.id}}/?type={{challenge.track}}#viewRegistrant")
12+
a.registrants(ng-href="https://{{SUBDOMAIN}}.{{DOMAIN}}/challenge-details/{{challenge.id}}/?type={{challenge.track}}#viewRegistrant")
1313
.registrants-icon
1414

1515
p {{challenge.numRegistrants}}
1616

17-
a.submissions(ng-href="https://www.{{DOMAIN}}/challenge-details/{{challenge.id}}/?type={{challenge.track}}#submissions")
17+
a.submissions(ng-href="https://{{SUBDOMAIN}}.{{DOMAIN}}/challenge-details/{{challenge.id}}/?type={{challenge.track}}#submissions")
1818
.submissions-icon
1919

2020
p {{challenge.numSubmissions}}

app/filters/challengeLinks.filter.js

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,7 @@ import _ from 'lodash'
4545
} else {
4646
data = {
4747
domain: CONSTANTS.domain,
48+
subdomain: location.href.search('//members') >= 0 ? 'members' : 'www',
4849
track: challenge.track.toLowerCase(),
4950
forumId: challenge.forumId,
5051
id: challenge.id
@@ -61,13 +62,13 @@ import _ from 'lodash'
6162
}
6263
/*eslint no-fallthrough:0*/
6364
case 'submissions':
64-
return String.supplant('https://www.{domain}/challenge-details/{id}/?type={track}#submissions', data)
65+
return String.supplant('https://{subdomain}.{domain}/challenge-details/{id}/?type={track}#submissions', data)
6566
case 'registrants':
66-
return String.supplant('https://www.{domain}/challenge-details/{id}/?type={track}#viewRegistrant', data)
67+
return String.supplant('https://{subdomain}.{domain}/challenge-details/{id}/?type={track}#viewRegistrant', data)
6768
case 'submit':// TODO use details link for submit, we can replace it with new submission page url
68-
return String.supplant('https://www.{domain}/challenge-details/{id}/?type={track}', data)
69+
return String.supplant('https://{subdomain}.{domain}/challenge-details/{id}/?type={track}', data)
6970
case 'detail':
70-
return String.supplant('https://www.{domain}/challenge-details/{id}/?type={track}', data)
71+
return String.supplant('https://{subdomain}.{domain}/challenge-details/{id}/?type={track}', data)
7172
}
7273
}
7374
}

0 commit comments

Comments
 (0)