Skip to content

Commit 562d156

Browse files
committed
fix issues
1 parent 0b279f5 commit 562d156

File tree

5 files changed

+8
-8
lines changed

5 files changed

+8
-8
lines changed

src/projects/detail/ProjectDetail.jsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -76,6 +76,7 @@ const ProjectDetailView = (props) => {
7676
isProcessing: props.isProcessing,
7777
allProductTemplates: props.allProductTemplates,
7878
productsTimelines: props.productsTimelines,
79+
location: props.location,
7980
}
8081
return <Component {...componentProps} />
8182
}

src/projects/detail/components/PhaseFeed/PhaseFeed.jsx

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -22,13 +22,6 @@ class PhaseFeedView extends React.Component {
2222
!_.isEmpty(this.props.location.hash) && this.handleUrlHash(this.props)
2323
}
2424

25-
componentDidUpdate(prevProps) {
26-
const { location } = this.props
27-
if (!_.isEmpty(location.hash) && location.hash !== prevProps.location.hash) {
28-
this.handleUrlHash(this.props)
29-
}
30-
}
31-
3225
// when the phase feed is actually loaded/rendered scroll to the appropriate post depending on url hash
3326
handleUrlHash(props) {
3427
const hashParts = _.split(location.hash.substring(1), '-')

src/projects/detail/components/ProjectStages.jsx

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -94,13 +94,15 @@ const ProjectStages = ({
9494
collapseProjectPhase,
9595
feedId,
9696
commentId,
97+
location
9798
}) => (
9899
<Section>
99100

100101
<PhaseCardListHeader {...formatPhaseCardListHeaderProps(phases)}/>
101102
{
102103
phases.map((phase, index) => (
103104
<ProjectStage
105+
location={location}
104106
key={phase.id}
105107
phaseState={phasesStates[phase.id]}
106108
productTemplates={productTemplates}

src/projects/detail/containers/DashboardContainer.jsx

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -112,6 +112,7 @@ class DashboardContainer extends React.Component {
112112
phasesTopics,
113113
expandProjectPhase,
114114
collapseProjectPhase,
115+
location,
115116
} = this.props
116117

117118
// system notifications
@@ -125,6 +126,7 @@ class DashboardContainer extends React.Component {
125126

126127
const leftArea = (
127128
<ProjectInfoContainer
129+
location={location}
128130
currentMemberRole={currentMemberRole}
129131
project={project}
130132
phases={phases}

src/projects/detail/containers/ProjectPlanContainer.jsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,8 @@ class ProjectPlanContainer extends React.Component {
9696
productsTimelines,
9797
phasesTopics,
9898
isProcessing,
99-
isLoadingPhases
99+
isLoadingPhases,
100+
location
100101
} = this.props
101102

102103
// manager user sees all phases
@@ -114,6 +115,7 @@ class ProjectPlanContainer extends React.Component {
114115

115116
const leftArea = (
116117
<ProjectInfoContainer
118+
location={location}
117119
currentMemberRole={currentMemberRole}
118120
phases={phases}
119121
project={project}

0 commit comments

Comments
 (0)