fix: change milestone.type to const type

Author: yoution

config/constants/dev.js

@@ -43,6 +43,7 @@ module.exports = {
   PREDIX_PROGRAM_ID         : 3448,
   IBM_COGNITIVE_PROGRAM_ID  : 3449,
   HEAP_ANALYTICS_APP_ID     : '4153837120',
+  PHASE_PRODUCT_TEMPLATE_ID : 166,
 
   TC_NOTIFICATION_URL: 'https://api.topcoder-dev.com/v5/notifications',
   CONNECT_MESSAGE_API_URL: 'https://api.topcoder-dev.com/v5',

config/constants/master.js

@@ -43,6 +43,7 @@ module.exports = {
   PREDIX_PROGRAM_ID         : 3448,
   IBM_COGNITIVE_PROGRAM_ID  : 3449,
   HEAP_ANALYTICS_APP_ID     : '638908330',
+  PHASE_PRODUCT_TEMPLATE_ID : 166,
 
   TC_NOTIFICATION_URL: 'https://api.topcoder.com/v5/notifications',
   CONNECT_MESSAGE_API_URL: 'https://api.topcoder.com/v5',

config/constants/qa.js

@@ -42,6 +42,7 @@ module.exports = {
   PREDIX_PROGRAM_ID         : 3448,
   IBM_COGNITIVE_PROGRAM_ID  : 3449,
   HEAP_ANALYTICS_APP_ID     : '4153837120',
+  PHASE_PRODUCT_TEMPLATE_ID : 166,
 
   TC_NOTIFICATION_URL: 'https://api.topcoder-dev.com/v5/notifications',
   CONNECT_MESSAGE_API_URL: 'https://api.topcoder-qa.com/v5',

src/config/constants.js

@@ -1111,24 +1111,6 @@ export const PROJECT_TYPE_TALENT_AS_A_SERVICE = 'talent-as-a-service'
  */
 export const TAAS_APP_URL = process.env.TAAS_APP_URL || 'https://mfe.topcoder-dev.com/taas'
 
-/**
- *  Milestone Type Options
- */
-export const MILESTONE_TYPE_OPTIONS = [
-  {
-    title: 'Reporting',
-    value: 'reporting',
-  },
-  {
-    title: 'Deliverable Review',
-    value: 'deliverable-review',
-  },
-  {
-    title: 'Final Deliverable Review',
-    value: 'final-deliverable-review',
-  },
-]
-
 /**
  * Milestone Types
  */
@@ -1150,8 +1132,25 @@ export const MILESTONE_TYPE = {
   DELIVERY: 'delivery'
 }
 
+/**
+ *  Milestone Type Options
+ */
+export const MILESTONE_TYPE_OPTIONS = [
+  {
+    title: 'Reporting',
+    value: MILESTONE_TYPE.REPORTING,
+  },
+  {
+    title: 'Deliverable Review',
+    value: MILESTONE_TYPE.DELIVERABLE_REVIEW,
+  },
+  {
+    title: 'Final Deliverable Review',
+    value: MILESTONE_TYPE.FINAL_DELIVERABLE_REVIEW,
+  },
+]
 
 /**
  *  project template id
  */
-export const PROJECT_TEMPLATE_ID = 166
+export const PHASE_PRODUCT_TEMPLATE_ID = process.env.PHASE_PRODUCT_TEMPLATE_ID

src/projects/actions/productsTimelines.js

@@ -24,6 +24,7 @@ import {
   SUBMIT_FINAL_FIXES_REQUEST_SUCCESS,
   SUBMIT_FINAL_FIXES_REQUEST_FAILURE,
   CREATE_TIMELINE_MILESTONE,
+  MILESTONE_TYPE,
   MILESTONE_STATUS,
   UPDATE_PRODUCT_TIMELINE,
   PHASE_STATUS_COMPLETED,
@@ -226,10 +227,10 @@ export function completeProductMilestone(productId, timelineId, milestoneId, upd
         prevMilestoneContent: completedMilestone.details.content,
         prevMilestoneType: completedMilestone.type,
       }
-      if ( ((nextMilestone.type === 'checkpoint-review' || nextMilestone.type === 'final-designs') // case # 2
-        && completedMilestone.type === 'add-links' ) ||
-        ((nextMilestone.type === 'delivery-design' || nextMilestone.type === 'delivery-dev') // case # 4
-          && completedMilestone.type !== 'final-fix' ) ) {
+      if ( ((nextMilestone.type === MILESTONE_TYPE.CHECKPOINT_REVIEW || nextMilestone.type === MILESTONE_TYPE.FINAL_DESIGNS) // case # 2
+        && completedMilestone.type === MILESTONE_TYPE.ADD_LINKS ) ||
+        ((nextMilestone.type === MILESTONE_TYPE.DELIVERY_DESIGN || nextMilestone.type === MILESTONE_TYPE.DELIVERY_DEV) // case # 4
+          && completedMilestone.type !== MILESTONE_TYPE.FINAL_FIX) ) {
         details.metadata = {
           ..._.get(nextMilestone.details, 'metadata', {}),
           waitingForCustomer: true
@@ -343,7 +344,7 @@ export function submitFinalFixesRequest(productId, timelineId, milestoneId, fina
 
     let finalFixesMilestone = timeline.milestones[milestoneIdx - 1]
 
-    if (!finalFixesMilestone || finalFixesMilestone.type !== 'final-fix') {
+    if (!finalFixesMilestone || finalFixesMilestone.type !== MILESTONE_TYPE.FINAL_FIX) {
       throw new Error('Cannot find final-fix milestone.')
     }
 
@@ -506,7 +507,7 @@ export function submitDeliverableFinalFixesRequest(productId, timelineId, milest
     ).updatedTimelineMilestones
 
     const finalFixesMilestone = {
-      type: 'deliverable-final-fixes',
+      type: MILESTONE_TYPE.DELIVERABLE_FINAL_FIXES,
       startDate: milestone.endDate,
       endDate: moment(milestone.endDate).add(3, 'day').toISOString(),
       status: MILESTONE_STATUS.ACTIVE,

src/projects/detail/components/timeline/milestones/MilestoneTypeCheckpointReview/MilestoneTypeCheckpointReview.jsx

@@ -17,6 +17,7 @@ import { getMilestoneStatusText, getDaysLeft, getTotalDays, getProgressPercent,
 import {
   MILESTONE_STATUS,
   MIN_CHECKPOINT_REVIEW_DESIGNS,
+  MILESTONE_TYPE,
 } from '../../../../../../config/constants'
 
 import './MilestoneTypeCheckpointReview.scss'
@@ -29,7 +30,7 @@ class MilestoneTypeCheckpointReview extends React.Component {
 
     this.state = {
       selectedLinks: [],
-      isLinksProvided: _.get(props.milestone, 'details.prevMilestoneType') === 'add-links',
+      isLinksProvided: _.get(props.milestone, 'details.prevMilestoneType') === MILESTONE_TYPE.ADD_LINKS,
       isSelectWarningVisible: false,
       isShowCompleteConfirmMessage: false,
     }

src/projects/detail/components/timeline/milestones/MilestoneTypeDeliverableReview/MilestoneTypeDeliverableReview.jsx

@@ -15,6 +15,7 @@ import { withMilestoneExtensionRequest } from '../../MilestoneExtensionRequest'
 import { getMilestoneStatusText } from '../../../../../../helpers/milestoneHelper'
 
 import {
+  MILESTONE_TYPE,
   MILESTONE_STATUS
 } from '../../../../../../config/constants'
 
@@ -215,7 +216,7 @@ class MilestoneTypeDeliverableReview extends React.Component {
           <div className="flex column middle" styleName="btns-container-vertical">
 
             {/* For milestone type of 'deliverable-final-fixes' specifically */}
-            {milestone.type === 'deliverable-final-fixes' && (
+            {milestone.type === MILESTONE_TYPE.DELIVERABLE_FINAL_FIXES && (
               <div styleName="fullwidth">
                 <div styleName="view-report-text">{milestoneDeliverableFinalFixesRequest}</div>
               </div>
@@ -250,7 +251,7 @@ class MilestoneTypeDeliverableReview extends React.Component {
             )}
 
             {/* Feedback link */}
-            {milestone.type !== 'deliverable-final-fixes' && (
+            {milestone.type !== MILESTONE_TYPE.DELIVERABLE_FINAL_FIXES && (
               isAddingFeedbackLink ? (
                 <div styleName="fullwidth">
                   <LinkItemForm
@@ -319,7 +320,7 @@ class MilestoneTypeDeliverableReview extends React.Component {
           </div>
 
           {/* For milestone types other than 'final-deliverable-review' specifically */}
-          {milestone.type !== 'final-deliverable-review' && (
+          {milestone.type !== MILESTONE_TYPE.FINAL_DELIVERABLE_REVIEW && (
             isActive && canAcceptFinalDelivery && (
               <div className="flex center" styleName="review-complete-btn-container">
                 <button type="button" className="tc-btn tc-btn-primary" onClick={this.onClickReviewComplete} disabled={milestoneSubmissionLinks.length === 0}>Review Complete</button>
@@ -328,7 +329,7 @@ class MilestoneTypeDeliverableReview extends React.Component {
           )}
 
           {/* For milestone type of 'final-deliverable-review' specifically */}
-          {milestone.type === 'final-deliverable-review' && (
+          {milestone.type === MILESTONE_TYPE.FINAL_DELIVERABLE_REVIEW && (
             isActive && canAcceptFinalDelivery && (
               isAdddingFinalFixesRequest ? (
                 <div styleName="fullwidth">

src/projects/detail/components/timeline/milestones/MilestoneTypeDelivery/MilestoneTypeDelivery.jsx

@@ -14,7 +14,7 @@ import MilestoneDescription from '../../MilestoneDescription'
 import MilestoneDelayNotification from '../../MilestoneDelayNotification'
 import { getMilestoneStatusText } from '../../../../../../helpers/milestoneHelper'
 import { hasPermission } from '../../../../../../helpers/permissions'
-import { MILESTONE_STATUS } from '../../../../../../config/constants'
+import { MILESTONE_STATUS, MILESTONE_TYPE } from '../../../../../../config/constants'
 
 import './MilestoneTypeDelivery.scss'
 import { PERMISSIONS } from '../../../../../../config/permissions'
@@ -23,19 +23,19 @@ import { PERMISSIONS } from '../../../../../../config/permissions'
   Acceptance dialogue messages based on the milestone type
 */
 const acceptDialogue = {
-  'delivery-dev': {
+  [MILESTONE_TYPE.DELIVERY_DEV]: {
     title: 'Code acceptance',
     text: 'Do you need any refinement on winner’s code before we deliver you the final source files? Some refinement or final fixes outside the project scope may cost you additional payment',
     button: 'Accept code',
   },
-  'delivery-design': {
+  [MILESTONE_TYPE.DELIVERY_DESIGN]: {
     title: 'Design acceptance',
     text: 'Do you need any refinement on winner’s design before we deliver you the final source files? Some refinement or final fixes outside the project scope may cost you additional payment',
     button: 'Accept design',
   },
   // TODO this is a temporary fallback for already created milestones in DEV backend
   // this is just to keep already created milestones working and can be removed when we don't touch such projects anymore
-  delivery: {
+  [MILESTONE_TYPE.DELIVERY]: {
     title: 'Work acceptance',
     text: 'Do you need any refinement on winner’s work before we deliver you the final source files? Some refinement or final fixes outside the project scope may cost you additional payment',
     button: 'Accept work',
@@ -194,7 +194,7 @@ class MilestoneTypeDelivery extends React.Component {
 
     const canSubmitFinalFixes = _.some(finalFixRequests, (finalFixRequest) => !!finalFixRequest.value)
 
-    const isFinalFixPresent = previousMilestone === 'final-fix'
+    const isFinalFixPresent = previousMilestone === MILESTONE_TYPE.FINAL_FIX
     let links = ''
     const deliveryButtons = [{ title: acceptDialogue[milestone.type].button, onClick: this.acceptDesign, type: 'primary' }]
     if(isFinalFixPresent) {

src/projects/detail/components/timeline/milestones/MilestoneTypeFinalDesigns/MilestoneTypeFinalDesigns.jsx

@@ -19,6 +19,7 @@ import {
   MILESTONE_STATUS,
   MIN_WINNER_DESIGNS,
   DEFAULT_ADDITIONAL_DESIGN_COST,
+  MILESTONE_TYPE 
 } from '../../../../../../config/constants'
 
 import './MilestoneTypeFinalDesigns.scss'
@@ -36,7 +37,7 @@ class MilestoneTypeFinalDesigns extends React.Component {
       additionalDesignCost: _.get(props, 'milestone.details.metadata.additionalDesignCost', DEFAULT_ADDITIONAL_DESIGN_COST),
       selectedLinks: [],
       places: _.fill(Array(requiredWinnersCount), -1), // produces array like [-1, -1, -1, ... , -1]
-      isLinksProvided: _.get(props.milestone, 'details.prevMilestoneType') === 'add-links',
+      isLinksProvided: _.get(props.milestone, 'details.prevMilestoneType') === MILESTONE_TYPE.ADD_LINKS,
       isShowCompleteConfirmMessage: false,
       isShowCustomerCompleteConfirmMessage: false,
     }

src/projects/detail/containers/DashboardContainer.jsx

@@ -60,7 +60,7 @@ import {
   PHASE_STATUS_DRAFT,
   SCREEN_BREAKPOINT_MD,
   CODER_BOT_USERID,
-  PROJECT_TEMPLATE_ID,
+  PHASE_PRODUCT_TEMPLATE_ID
 } from '../../../config/constants'
 
 const SYSTEM_USER = {
@@ -120,7 +120,7 @@ class DashboardContainer extends React.Component {
 
     const projectTemplate = {
       name: phase.title,
-      id: PROJECT_TEMPLATE_ID,
+      id: PHASE_PRODUCT_TEMPLATE_ID,
     }
 
     createPhaseAndMilestones(project, projectTemplate, type, phase.startDate, phase.endDate, milestones)