refactor: remove redundant code and rename var

- rename projectTemplate to productTemplate for phases&products
- removed redundant code

Author: maxceem

src/api/projects.js

@@ -184,26 +184,6 @@ export function createPhaseProduct(projectId, phaseId, product) {
     .then( resp => resp.data)
 }
 
-export function createProjectWithStatus(projectProps, status) {
-  // Phase out discussions
-  // TODO: Remove this once none of the active projects
-  // have the discussions tab enabled
-  projectProps.details.hideDiscussions = true
-
-  return axios.post(`${PROJECTS_API_URL}/v5/projects/`, projectProps)
-    .then( resp => resp.data)
-    .then(project => {
-      const updatedProps = { status }
-      const projectId = project.id
-      return axios.patch(`${PROJECTS_API_URL}/v5/projects/${projectId}/`, updatedProps)
-        .then(resp => resp.data)
-        .catch(error => { // eslint-disable-line no-unused-vars
-          // return created project even if status update fails to prevent error page
-          return project
-        })
-    })
-}
-
 export function deleteProject(projectId) {
   return axios.delete(`${PROJECTS_API_URL}/v5/projects/${projectId}/`)
     .then(() => {

src/projects/actions/project.js

@@ -3,7 +3,6 @@ import moment from 'moment'
 import { flatten, unflatten } from 'flat'
 import { getProjectById,
   createProject as createProjectAPI,
-  createProjectWithStatus as createProjectWithStatusAPI,
   updateProject as updateProjectAPI,
   deleteProject as deleteProjectAPI,
   deleteProjectPhase as deleteProjectPhaseAPI,
@@ -275,16 +274,16 @@ function createProductsTimelineAndMilestone(project) {
  * Create phase and product for the project
  *
  * @param {Object} project         project
- * @param {Object} projectTemplate project template
+ * @param {Object} productTemplate product template
  * @param {String} status          (optional) project/phase status
  *
  * @return {Promise} project
  */
-export function createProjectPhaseAndProduct(project, projectTemplate, status = PHASE_STATUS_DRAFT, startDate, endDate) {
+export function createProjectPhaseAndProduct(project, productTemplate, status = PHASE_STATUS_DRAFT, startDate, endDate) {
   const param = {
     status,
-    name: projectTemplate.name,
-    productTemplateId: projectTemplate.id
+    name: productTemplate.name,
+    productTemplateId: productTemplate.id
   }
   if (startDate) {
     param['startDate'] = startDate.format('YYYY-MM-DD')
@@ -309,16 +308,16 @@ export function createProjectPhaseAndProduct(project, projectTemplate, status =
  * Create phase and product and milestones for the project
  *
  * @param {Object} project         project
- * @param {Object} projectTemplate project template
+ * @param {Object} productTemplate product template
  * @param {String} status          (optional) project/phase status
  * @param {Object} startDate       phase startDate
  * @param {Object} endDate         phase endDate
  * @param {Array}  milestones      milestones
  *
  * @return {Promise} project
  */
-function createPhaseAndMilestonesRequest(project, projectTemplate, status = PHASE_STATUS_DRAFT, startDate, endDate, milestones) {
-  return createProjectPhaseAndProduct(project, projectTemplate, status, startDate, endDate).then(({timeline, phase, project, product}) => {
+function createPhaseAndMilestonesRequest(project, productTemplate, status = PHASE_STATUS_DRAFT, startDate, endDate, milestones) {
+  return createProjectPhaseAndProduct(project, productTemplate, status, startDate, endDate).then(({timeline, phase, project, product}) => {
     // we have to add delay before creating milestones in newly created timeline
     // to make sure timeline is created in ES, otherwise it may happen that we would try to add milestones
     // into timeline before timeline existent in ES
@@ -332,12 +331,11 @@ function createPhaseAndMilestonesRequest(project, projectTemplate, status = PHAS
   })
 }
 
-
-export function createPhaseAndMilestones(project, projectTemplate, status, startDate, endDate, milestones) {
+export function createPhaseAndMilestones(project, productTemplate, status, startDate, endDate, milestones) {
   return (dispatch, getState) => {
     return dispatch({
       type: CREATE_PROJECT_PHASE_TIMELINE_MILESTONES,
-      payload: createPhaseAndMilestonesRequest(project, projectTemplate, status, startDate, endDate, milestones)
+      payload: createPhaseAndMilestonesRequest(project, productTemplate, status, startDate, endDate, milestones)
     }).then(() => {
       const state = getState()
       const project = state.projectState.project
@@ -555,19 +553,6 @@ export function updateProduct(projectId, phaseId, productId, updatedProps) {
   }
 }
 
-export function createProjectWithStatus(newProject, status, projectTemplate) {
-  return (dispatch) => {
-    return dispatch({
-      type: CREATE_PROJECT,
-      payload: createProjectWithStatusAPI(newProject, status)
-        .then((project) => {
-          return createProjectPhaseAndProduct(project, projectTemplate, status)
-            .then(() => project)
-        })
-    })
-  }
-}
-
 export function deleteProject(newProject) {
   return (dispatch) => {
     return dispatch({

src/projects/detail/containers/DashboardContainer.jsx

@@ -118,12 +118,12 @@ class DashboardContainer extends React.Component {
   onFormSubmit(type, phase, milestones) {
     const { project, createPhaseAndMilestones } = this.props
 
-    const projectTemplate = {
+    const productTemplate = {
       name: phase.title,
       id: PHASE_PRODUCT_TEMPLATE_ID,
     }
 
-    createPhaseAndMilestones(project, projectTemplate, type, phase.startDate, phase.endDate, milestones)
+    createPhaseAndMilestones(project, productTemplate, type, phase.startDate, phase.endDate, milestones)
   }