Skip to content
This repository was archived by the owner on Mar 13, 2025. It is now read-only.

[$400] Project UBahn | Audit APIs #48

Closed
callmekatootie opened this issue Oct 2, 2020 · 9 comments
Closed

[$400] Project UBahn | Audit APIs #48

callmekatootie opened this issue Oct 2, 2020 · 9 comments

Comments

@callmekatootie
Copy link
Collaborator

Audit the existing apis to ensure that they conform to the v5 standards

@callmekatootie callmekatootie changed the title Audit APIs [$400] Project UBahn | Audit APIs Oct 2, 2020
@cwdcwd
Copy link
Contributor

cwdcwd commented Oct 2, 2020

Contest https://www.topcoder.com/challenges/30144386 has been created for this ticket.

This is an automated message for lazybaer via Topcoder X

@cwdcwd
Copy link
Contributor

cwdcwd commented Oct 2, 2020

Contest https://www.topcoder.com/challenges/30144386 has been updated - it has been assigned to xxcxy.

This is an automated message for lazybaer via Topcoder X

@callmekatootie
Copy link
Collaborator Author

callmekatootie commented Oct 6, 2020

  • These endpoints are not having header pagination information. Additionally, the page attribute has no effect if the records are fetched from db and not ES
    get /users
    get /users/{userId}/skills
    get /skills
    get /skillsProviders
    get /roles
    get /users/{userId}/roles
    get /users/{userId}/externalProfiles
    get /users/{userId}/achievements
    get /achievementsProviders
    get /organizations
    get /organizations/{organizationId}/skillProviders
    get /users/{userId}/attributes
    get /attributes
    get /attributeGroups

@callmekatootie
Copy link
Collaborator Author

  • These endpoints are not having pagination information
    head /users
    head /users/{userId}/skills
    head /skills
    head /skillsProviders
    head /roles
    head /users/{userId}/roles
    head /users/{userId}/externalProfiles
    head /users/{userId}/achievements
    head /achievementsProviders
    head /organizations
    head /organizations/{organizationId}/skillProviders
    head /users/{userId}/attributes
    head /attributes
    head /attributeGroups

@callmekatootie
Copy link
Collaborator Author

  • These endpoints have PATCH method but not PUT
    /users/{userId}
    /users/{userId}/skills/{skillId}
    /skills/{skillId}
    /skillsProviders/{providerId}
    /roles/{roleId}
    /users/{userId}/roles/{roleId}
    /users/{userId}/externalProfiles/{organizationId}
    /users/{userId}/achievements/{achievementsProviderId}
    /achievementsProviders/{providerId}
    /organizations/{organizationId}
    /organizations/{organizationId}/skillProviders/{skillProviderId}
    /users/{userId}/attributes/{attributeId}
    /attributes/{attributeId}
    /attributeGroups/{id}

@callmekatootie
Copy link
Collaborator Author

  • Missing HEAD method:
    get /skill-search/users
    get /skill-search/userAttributes
    get /skill-search/userAchievements
    get /skill-search/skills

@callmekatootie
Copy link
Collaborator Author

callmekatootie commented Oct 6, 2020

  • Missing pagination header info
    post /skill-search/users

@callmekatootie
Copy link
Collaborator Author

  • Should use get method, not post method. Should use query parameters instead of request body
    post /skill-search/users

  • Does not support pagination
    get /skill-search/userAttributes
    get /skill-search/userAchievements
    get /skill-search/skills

@cwdcwd
Copy link
Contributor

cwdcwd commented Oct 6, 2020

Payment task has been updated: https://software.topcoder.com/review/actions/ViewProjectDetails?pid=30144386

This is an automated message for lazybaer via Topcoder X

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants