-
Notifications
You must be signed in to change notification settings - Fork 52
[$125] Fix service calls on root page #171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Contest https://www.topcoder.com/challenges/30123331 has been created for this ticket. |
Contest https://www.topcoder.com/challenges/30123331 has been updated - it has been assigned to diazz. |
@jmgasper we don't implement pagination. we just loop to get all challenge. For this i have to add pagination ui and handle the pagination control. There are also some filter by search field + status go with pagination. Also there are some problem in redux control make the app request multiple time. Can you check the prize for this task again? |
@suppermancool - My bad. Fixed. |
topcoder-platform#171 Fix service calls on root page
@jmgasper hey please wait to check, i'm getting some problem when changing project |
@suppermancool - Sorry, got a little excited 😆 |
#171 fix load challenge after change project id
Payment task has been updated: https://software.topcoder.com/review/actions/ViewProjectDetails?pid=30123331 |
When the root page (
/
) loads, we show theActive Challenges
tab selected and the list of all challenges for the logged in user, across all projects.This works, but it makes too many requests to the services. Tested in Firefox on macOS Catalina.
Note - this should be fixed for all 3 tabs :
Issue 1
I'm seeing duplicate calls to the same endpoint with the same parameters. This shouldn't happen.
Issue 2
We're not paginating in the table properly - we're just loading the first two pages and displaying the results. Instead, we should add pagination controls to the table and only load the first "chunk" of challenges when the page first loads, allowing the user to paginate. Pagination should work with or without a search term filter.
The text was updated successfully, but these errors were encountered: