Skip to content

[$125] Fix service calls on root page #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jmgasper opened this issue Apr 27, 2020 · 8 comments
Closed

[$125] Fix service calls on root page #171

jmgasper opened this issue Apr 27, 2020 · 8 comments

Comments

@jmgasper
Copy link
Collaborator

jmgasper commented Apr 27, 2020

When the root page (/) loads, we show the Active Challenges tab selected and the list of all challenges for the logged in user, across all projects.

This works, but it makes too many requests to the services. Tested in Firefox on macOS Catalina.

Note - this should be fixed for all 3 tabs :

  • Active
  • Draft
  • Completed

Issue 1

I'm seeing duplicate calls to the same endpoint with the same parameters. This shouldn't happen.

Screen_Shot_2020-04-27_at_11_14_47

Issue 2

We're not paginating in the table properly - we're just loading the first two pages and displaying the results. Instead, we should add pagination controls to the table and only load the first "chunk" of challenges when the page first loads, allowing the user to paginate. Pagination should work with or without a search term filter.

@jmgasper
Copy link
Collaborator Author

Contest https://www.topcoder.com/challenges/30123331 has been created for this ticket.

This is an automated message for ghostar via Topcoder X

@jmgasper
Copy link
Collaborator Author

Contest https://www.topcoder.com/challenges/30123331 has been updated - it has been assigned to diazz.

This is an automated message for ghostar via Topcoder X

@suppermancool
Copy link
Collaborator

suppermancool commented Apr 27, 2020

@jmgasper we don't implement pagination. we just loop to get all challenge. For this i have to add pagination ui and handle the pagination control. There are also some filter by search field + status go with pagination. Also there are some problem in redux control make the app request multiple time. Can you check the prize for this task again?

@jmgasper jmgasper changed the title [$40] Fix service calls on root page [$125] Fix service calls on root page Apr 27, 2020
@jmgasper
Copy link
Collaborator Author

@suppermancool - My bad. Fixed.

suppermancool added a commit to suppermancool/topcoder-platform-challenge-engine-ui that referenced this issue Apr 27, 2020
jmgasper added a commit that referenced this issue Apr 27, 2020
@suppermancool
Copy link
Collaborator

@jmgasper hey please wait to check, i'm getting some problem when changing project

@jmgasper
Copy link
Collaborator Author

@suppermancool - Sorry, got a little excited 😆

@suppermancool
Copy link
Collaborator

@jmgasper done in #177

please run npm i before checking

jmgasper added a commit that referenced this issue Apr 27, 2020
#171 fix load challenge after change project id
@jmgasper
Copy link
Collaborator Author

Payment task has been updated: https://software.topcoder.com/review/actions/ViewProjectDetails?pid=30123331

This is an automated message for ghostar via Topcoder X

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants