Merge pull request #3296 from r0hit-gupta/heading-fix

Issue #3245 | Add H1 heading

Author: sushilshinde

__tests__/shared/components/challenge-listing/Filters/FiltersCardsType.jsx

@@ -27,6 +27,6 @@ class Wrapper extends React.Component {
 test('handle events', () => {
   const instance = TU.renderIntoDocument((<Wrapper />));
   const matches = TU.scryRenderedDOMComponentsWithTag(instance, 'a');
-  expect(matches).toHaveLength(2);
+  expect(matches).toHaveLength(1);
   TU.Simulate.click(matches[0]);
 });

__tests__/shared/components/challenge-listing/Filters/__snapshots__/FiltersCardsType.jsx.snap

@@ -4,13 +4,11 @@ exports[`Matches shallow shapshot 1`] = `
 <div
   className="src-shared-components-challenge-listing-Filters-FiltersCardsType-___style__cards-type-col___39JxY"
 >
-  <a
+  <h1
     className=""
-    onClick={[Function]}
-    onKeyPress={[Function]}
   >
     Challenges
-  </a>
+  </h1>
   <a
     href="https://arena.topcoder-dev.com"
     rel="noopener noreferrer"
@@ -25,13 +23,11 @@ exports[`Matches shallow shapshot 2`] = `
 <div
   className="src-shared-components-challenge-listing-Filters-FiltersCardsType-___style__cards-type-col___39JxY"
 >
-  <a
+  <h1
     className=""
-    onClick={[Function]}
-    onKeyPress={[Function]}
   >
     Challenges
-  </a>
+  </h1>
   <a
     href="https://arena.topcoder-dev.com"
     rel="noopener noreferrer"

src/shared/components/challenge-listing/Filters/FiltersCardsType/index.jsx

@@ -13,13 +13,11 @@ import './style.scss';
 
 const FiltersCardsType = ({ hideSrm, isCardTypeSet }) => (
   <div styleName="cards-type-col">
-    <a
+    <h1
       styleName={`${isCardTypeSet === 'Challenges' ? 'active' : ''}`}
-      onClick={e => e.preventDefault()}
-      onKeyPress={e => e.preventDefault()}
     >
 Challenges
-    </a>
+    </h1>
     {
       hideSrm ? null : (
         <a

src/shared/components/challenge-listing/Filters/FiltersCardsType/style.scss

@@ -10,7 +10,8 @@ $type-radius-4: $corner-radius * 2;
   vertical-align: middle;
   font-size: 0;
 
-  > a {
+  > a,
+  h1 {
     @include roboto-regular;
 
     height: $type-space-60;