Skip to content

Github ticket rules #1543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ThomasKranitsas opened this issue Sep 21, 2018 · 5 comments
Open

Github ticket rules #1543

ThomasKranitsas opened this issue Sep 21, 2018 · 5 comments
Labels

Comments

@ThomasKranitsas
Copy link
Contributor

ThomasKranitsas commented Sep 21, 2018

How to work with git tickets

The basic flow for handling a ticket is as follows:

  1. Assign the ticket to yourself, change the label to "tcx_Assigned", remove the "tcx_OpenForPickup" label. Please only assign tickets to yourself when you are ready to work on it. I don't want tickets assigned to someone and then not have them work on a ticket for 24 hours. The goal here is a quick turnaround for the client. If you can't work on a ticket immediately, leave it for someone else.

  2. Complete the ticket and create a merge request within 24 hours. Please ensure your merge request can be merged automatically and that it's against the latest commit in Git when you create it.

  3. Change the label on the ticket to "tcx_ReadyForReview"

After seeing a ticket marked as "tcx_ReadyForReview", the copilot will review that ticket, usually within 24 hours.

Note that you are expected to keep your changes in-sync with Git - make sure to do a pull before you push changes to make sure there aren't any merge issues.

Accepted fix

If a fix is accepted, a payment ticket will be created on the Topcoder platform within 5-10 minutes of the issue being closed. You should see the payment in your PACTs within 24 hours.

Rejected fix

If a fix is rejected, a comment, and possibly a screenshot, will be added to the ticket explaining why the fix was rejected. The status will be changed to "tcx_Feedback".

If a fix is rejected, that ticket is your priority. You should not assign yourself any more tickets until you complete the required additional fixes!

Payment amounts

Each ticket in GitHub has a dollar value. That is the amount you will be paid when the ticket is completed, merged, and verified by the copilot. Note that there is still a 30 day waiting period as the payment will be treated as a regular TopCoder challenge payment.

Important Rules:

  • You can assign any unassigned issue to yourself with an "Open for pick up" label (first come first serve)

  • You can only assign ONE AT A TIME. The nature of it being assigned will indicate it is not available to anyone else.

  • You will fix the ticket by committing changes to the master branch.

  • After marking a ticket "tcx_ReadyForReview" you are eligible to accept another. You do NOT need to wait for the copilot to validate your fix.

  • You can do as many tickets as you want, as long as you follow the rules above.

  • If an assigned task is not done in 24 hours, you will need to explain why it is not completed as a comment on the ticket.

  • You can ask questions directly on the GitHub ticket.

ANYONE NOT FOLLOWING THE RULES ABOVE WILL BE WARNED AND POTENTIALLY LOSE THEIR GITHUB ACCESS!

@ThomasKranitsas
Copy link
Contributor Author

@topcoder-platform/topcodercompetitors we're currently running this Bug Bash challenge: https://www.topcoder.com/challenges/30071536

Make sure to register on the challenge and use the link from the forum to register with Topcoder-X otherwise you can't work on the tickets that are open for pickup.

Thank you!

@ThomasKranitsas
Copy link
Contributor Author

@topcoder-platform/topcodercompetitors do not modify the labels. Our system is going to take care of that.

@ThomasKranitsas
Copy link
Contributor Author

@topcoder-platform/topcodercompetitors please read the above rules carefully.

Few extra notes:

  • Please always check if someone is already working on the ticket you want to pick up. If so, please respect each other and do not change the assigned developer. Even if 24h have passed, you can tag me on the ticket and let me know that the deadline has passed and I'll take care of the rest.
  • If you can't assign yourself on a ticket, check the challenge forum. https://www.topcoder.com/challenges/30086765/?type=develop There is a link you can use to register with Topcoder-X. You will then be able to assign yourself on a ticket.

Thank you!

@ThomasKranitsas
Copy link
Contributor Author

@topcoder-platform/topcodercompetitors make sure to add the tcx_ReadyForReview label once your PR is ready for review.

@ThomasKranitsas
Copy link
Contributor Author

@topcoder-platform/topcodercompetitors I've opened a bunch of new issues for pick up! Let's get them fixed! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants