Skip to content

$25 | New Nav: When the screen is resized, second level selection moves #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nithyaasworld opened this issue Jun 4, 2019 · 26 comments
Assignees
Labels
Failed QA nav_Assigned nav_FixAccepted P3 Normal (resolved within 7 days) Test Env Environment

Comments

@nithyaasworld
Copy link
Collaborator

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://test-community-app.topcoder-dev.com/challenges
  2. Login
  3. Click on Work -> Compete
  4. All Challenges in the Second Level is selected and has a Green mark underneath it to indicate its the active section
  5. Resize the window and observe the Green mark.

Actual behavior
Green mark moves When the screen is resized.

Expected behavior
Green mark should not move

Screenshots
image

image

@nithyaasworld
Copy link
Collaborator Author

nithyaasworld commented Jun 4, 2019

Same issue exists with First Level Selection Pointer too.

image

@luizrrodrigues luizrrodrigues changed the title New Nav: When the screen is resized, second level selection moves $25 | New Nav: When the screen is resized, second level selection moves Jun 7, 2019
@RAJKUMARRRR
Copy link

how can i assign this issue to me?

@luizrrodrigues
Copy link
Collaborator

Just request in comments and I'll assign to you.

@luizrrodrigues
Copy link
Collaborator

Assigned to @RAJKUMARRRR

@RAJKUMARRRR
Copy link

ok, thank you

@luizrrodrigues
Copy link
Collaborator

@RAJKUMARRRR Any status on this?

@nahidshahin nahidshahin self-assigned this Jun 14, 2019
@luizrrodrigues
Copy link
Collaborator

@nahidshahin Any status on this.

Please send PR or update in next 12h or this one will open for pickup.

Thanks.

@nahidshahin nahidshahin removed their assignment Jun 15, 2019
@armaan6651
Copy link

armaan6651 commented Jun 16, 2019

Ignore. I am unable to run this in. my system. Will come back once it runs successfully.

@luizrrodrigues
Copy link
Collaborator

@armaan6651 Let me know what issue you found, maybe I can help.

@armaan6651
Copy link

armaan6651 commented Jun 16, 2019

@luizrrodrigues I was able to get it running. However, I am NOT getting the navbar from this issue.

Screenshot 2019-06-16 at 7 45 23 AM

@luizrrodrigues
Copy link
Collaborator

luizrrodrigues commented Jun 16, 2019

You need to use feature-new-nav branch

@yoution
Copy link
Contributor

yoution commented Jan 10, 2020

please assign to me

@sumitdaga sumitdaga self-assigned this Jan 10, 2020
@luizrrodrigues
Copy link
Collaborator

@sumitdaga Another member requested to sign before you.
Please take a look in issue historic, some member no able to self-assign

@luizrrodrigues
Copy link
Collaborator

@yoution Assign to you.

@luizrrodrigues luizrrodrigues assigned yoution and unassigned sumitdaga Jan 10, 2020
@yoution
Copy link
Contributor

yoution commented Jan 10, 2020

@luizrrodrigues I have pushed, please review, #84

@yoution
Copy link
Contributor

yoution commented Jan 11, 2020

something wrong with my workflow, please review this.#90

@luizrrodrigues luizrrodrigues transferred this issue from topcoder-platform/community-app Jan 14, 2020
@luizrrodrigues
Copy link
Collaborator

@yoution

  • The arrow mark moving from level 2 menu to level 1
  • Level 3 green mark, still moving (after move back to right position, but we looking for make this fixed)

Screen Recording 2020-01-14 at 05.43.39.mov.zip

@yoution
Copy link
Contributor

yoution commented Jan 14, 2020

@luizrrodrigues I will fix it

@yoution
Copy link
Contributor

yoution commented Jan 14, 2020

@luizrrodrigues the level3 green mark, must be static ?

@luizrrodrigues
Copy link
Collaborator

luizrrodrigues commented Jan 14, 2020

@yoution When resize, yes.

@yoution
Copy link
Contributor

yoution commented Jan 14, 2020

@luizrrodrigues #108
please review, sorry, I can not make the level3 green mark static, it may change a lot,
I just disable the animation when onresize, https://monosnap.com/file/JQm6w8MelhiTNKAJHby1yyyUoEeqPU, it will reduce movement effects

@luizrrodrigues
Copy link
Collaborator

@yoution Okay, thanks I'll review.

@luizrrodrigues
Copy link
Collaborator

@yoution Looks like not working in Community sub nav:
https://www.screencast.com/t/lfT9iv84V

yoution added a commit to yoution/navigation-component that referenced this issue Jan 15, 2020
@yoution
Copy link
Contributor

yoution commented Jan 15, 2020

@luizrrodrigues please review again, thanks, #120

luizrrodrigues added a commit that referenced this issue Jan 15, 2020
#95 New Nav: When the screen is resized, second level selection moves
@SathyaJayabal
Copy link
Collaborator

The first level selection pointer position is not right on window resizing. See some examples below.
Screenshot 2020-01-21 at 1 01 18 PM
Screenshot 2020-01-21 at 12 57 47 PM
Screenshot 2020-01-21 at 12 58 50 PM

@yoution
Copy link
Contributor

yoution commented Jan 21, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Failed QA nav_Assigned nav_FixAccepted P3 Normal (resolved within 7 days) Test Env Environment
Projects
None yet
Development

No branches or pull requests

10 participants