Skip to content

$75 | “More” tab is not swapping position with the first element to the left of the tab #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
codejamtc opened this issue Jun 7, 2019 · 29 comments
Open

$75 | “More” tab is not swapping position with the first element to the left of the tab #101

codejamtc opened this issue Jun 7, 2019 · 29 comments
Assignees
@yoution
Labels
Failed QA nav_Assigned nav_FixAccepted P3 Normal (resolved within 7 days) Test Env Environment

Comments

@codejamtc
Copy link

https://www.screencast.com/t/Gr2VNvQ8

  1. Open the application https://test-community-app.topcoder-dev.com/challenges
  2. Login as dan_developer (Landscape)
  3. Tap Menu > Work > More > Community

Actual: “More” tab is not swapping position with the first element to the left of the tab

Expected: Selecting an option from the “More” tab should become visible and swap position with the first element to the left of the tab. This functionality can be observed on Google search.

Reproducibility Rate: 3/3

Environment: Samsung Galaxy Tab A (2017), 7 inch

Browser: Chrome 75.0.3770.80
@luizrrodrigues luizrrodrigues self-assigned this Jun 11, 2019
@luizrrodrigues luizrrodrigues removed their assignment Jan 9, 2020
@luizrrodrigues luizrrodrigues changed the title “More” tab is not swapping position with the first element to the left of the tab $75 | “More” tab is not swapping position with the first element to the left of the tab Jan 9, 2020
@yoution
Copy link
Contributor

yoution commented Jan 9, 2020

please assign to me

@yoution
Copy link
Contributor

yoution commented Jan 10, 2020

how to reproduct the problem, the 'more' button is not show, how to show it

image

@luizrrodrigues
Copy link
Collaborator

@yoution Open in Firefox or reduce window size.

@yoution
Copy link
Contributor

yoution commented Jan 10, 2020 •
edited
Loading

image

if I click 'explore','complete' go to the 'explore' position or go to the first place before 'track'? there is only three tab in my account, could you give me a test account has more tabs

@luizrrodrigues
Copy link
Collaborator

@yoution This menu is same to all accounts.

What we looking is:

  • Click in More;
  • Click in Explore;
  • Will go to Explore page (like existing) and will swipe the Compete with Explore;

So in your screenshot above will be:
Explore - More [ Tracks - Compete ]

Like as Google Search menu works, check:

Screen Recording 2020-01-09 at 22.39.38.mov.zip

@yoution
Copy link
Contributor

yoution commented Jan 10, 2020

#83

I have pushed , please review

@yoution
Copy link
Contributor

yoution commented Jan 11, 2020

please use this, my workflow is someting wrong, #89

@luizrrodrigues luizrrodrigues transferred this issue from topcoder-platform/community-app Jan 14, 2020
@luizrrodrigues luizrrodrigues added nav_Assigned nav_ReadyForReview P3 Normal (resolved within 7 days) labels Jan 14, 2020
@yoution yoution mentioned this issue Jan 14, 2020
Closed
@luizrrodrigues
Copy link
Collaborator

@yoution I see the swapping, but if click in level 3 menu will swap again to original position.

Please check:

Screen Recording 2020-01-14 at 07.35.03.mov.zip

yoution added a commit to yoution/navigation-component that referenced this issue Jan 14, 2020
@yoution
topcoder-platform#101 fixed bug for "more" tab swapping position
67a924a
@yoution
Copy link
Contributor

yoution commented Jan 14, 2020

@luizrrodrigues please review

@yoution
Copy link
Contributor

yoution commented Jan 14, 2020

#107

@luizrrodrigues
Copy link
Collaborator

@yoution If access link directly, like:
http://local.topcoder.com/community/qa

swapping not working, still showing Community -> Compete - More

yoution added a commit to yoution/navigation-component that referenced this issue Jan 14, 2020
@yoution
topcoder-platform#101 add time interval after click thrid tab for net…
b9f3641 
…work is slow
@yoution
Copy link
Contributor

yoution commented Jan 14, 2020

@luizrrodrigues #107
two commit , I add new commit,please review

@luizrrodrigues
Copy link
Collaborator

@yoution Looks like not working in Firefox, working well in another browsers.

@yoution
Copy link
Contributor

yoution commented Jan 22, 2020

@luizrrodrigues the green indicator not show correctly when switch tab？I will check

@luizrrodrigues
Copy link
Collaborator

Yes, Green indicator show in wrong position when follow the steps above.

yoution added a commit to yoution/navigation-component that referenced this issue Jan 22, 2020
@yoution
topcoder-platform#101 green indicator error when switch tab from "more"
2166a3d
@yoution
Copy link
Contributor

yoution commented Jan 22, 2020

@luizrrodrigues please review
#128

@luizrrodrigues
Copy link
Collaborator

@yoution Please check video bellow, issue still exist:

Screen Recording 2020-01-27 at 20.51.36.mov.zip

yoution added a commit to yoution/navigation-component that referenced this issue Jan 28, 2020
@yoution
topcoder-platform#101 fixed green indicator again
87ca4e8
yoution added a commit to yoution/navigation-component that referenced this issue Jan 28, 2020
@yoution
topcoder-platform#101 green indicator error when switch tab from "more"
b5b0729
@yoution
Copy link
Contributor

yoution commented Jan 28, 2020

@luizrrodrigues please review again, thanks #149

@luizrrodrigues
Copy link
Collaborator

@yoution Cool, looks good now.

luizrrodrigues added a commit that referenced this issue Jan 28, 2020
@luizrrodrigues
Merge pull request #149 from yoution/issue_101
4247266 
#101 green indicator error when switch tab from "more"
@SathyaJayabal
Copy link
Collaborator

I am sorry but the issue in #141 still happens. See video
Screenshot 2020-01-28 at 6 42 49 PM
more issue.mov.zip

@luizrrodrigues
Copy link
Collaborator

@yoution This happen just showing "More" button, because function will try replace menu in More with no existing out from More.

So when screen in small and just More is showing, need ignore swipe function.

Make sense?

@SathyaJayabal SathyaJayabal mentioned this issue Jan 28, 2020
Closed
yoution added a commit to yoution/navigation-component that referenced this issue Jan 28, 2020
@yoution
topcoder-platform#101 fix bug when all submenus are in "more" menu
d03dc00
@SathyaJayabal
Copy link
Collaborator

@luizrrodrigues , Please make sure this issue is also fixed.
On a tab size window, when you click on more->menu->sub menu, the selection indicator moves from more to Community
#62 (comment)

selection indicator.mov.zip

@yoution
Copy link
Contributor

yoution commented Jan 28, 2020

@luizrrodrigues #150
have pushed, please review

yoution added a commit to yoution/navigation-component that referenced this issue Jan 29, 2020
@yoution
topcoder-platform#101 fix bug when all submenus are in "more" menu
a536feb
@yoution
Copy link
Contributor

yoution commented Jan 29, 2020

@luizrrodrigues I have pushed again, please review this one #151 . thanks

@macs054 macs054 added Beta Env Environment Test Env Environment and removed Test Env Environment Beta Env Environment labels Feb 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yoution yoution

Labels
Failed QA nav_Assigned nav_FixAccepted P3 Normal (resolved within 7 days) Test Env Environment
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@macs054 @yoution @luizrrodrigues @codejamtc @SathyaJayabal