Skip to content

Notifications Backend integration: Public group logic changes #4121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SathyaJayabal opened this issue Mar 18, 2020 · 4 comments
Closed

Notifications Backend integration: Public group logic changes #4121

SathyaJayabal opened this issue Mar 18, 2020 · 4 comments
Assignees
Milestone

Comments

@SathyaJayabal
Copy link
Collaborator

Public group logic changes - now excluding group like ["!CS", "!Zurich", "!Topgear"]

When a group is included in the filter like "groups": ["TestGroup"], then all members of the TestGroup will receive the notifications.

When a group is excluded in the filter like "groups": ["!TestGroup"], then all members excluding the members of TestGroup will receive the notifications.

So for example to send a public broadcast message the private group members of the CS, Zurich, Topgear groups will be excluded by using the filter "groups": ["!CS", "!Zurich", "!Topgear"]

cc @sachin-maheshwari @Oanh-and-only-Oanh

@SathyaJayabal
Copy link
Collaborator Author

verified on dev
When the groups filter is empty, then all users should receive the notification. But users belonging to any group. (eg:cognitive) do not receive the notification.

@SathyaJayabal SathyaJayabal added Dev Env Notifications QA Fail QA verification on Dev has failed. Assignee to redo the fix. labels Mar 18, 2020
@SathyaJayabal
Copy link
Collaborator Author

@sachin-maheshwari , When a ! is used, the members who do not belong to the group do not get the notification.
Example:
Users TonyJ and dan_developer

TonyJ is a member of Blockchain, dan_developer is not.

If the groups filter is "groups": ["Blockchain"] then the notification is displayed correctly(only for tonyj), but if the groups filter is "groups": ["!Blockchain"], then the notification is not displayed for both the users, it should display for dan_developer.

@SathyaJayabal
Copy link
Collaborator Author

@sachin-maheshwari , verified on test env.
When a group is included in the filter like "groups": ["TestGroup"], then all members of the TestGroup receive the notifications.

When a group is excluded in the filter like "groups": ["!TestGroup"], then all members excluding the members of TestGroup receive the notifications.

@SathyaJayabal SathyaJayabal added QA Pass and removed QA Fail QA verification on Dev has failed. Assignee to redo the fix. labels Mar 19, 2020
@SathyaJayabal SathyaJayabal added this to the v0.27.0 milestone Mar 30, 2020
@SathyaJayabal
Copy link
Collaborator Author

Can not be verified on production until a broadcast message is posted with the above filters.

@SathyaJayabal SathyaJayabal added Prod Env Environment and removed Dev Env labels Mar 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants