Skip to content

Ratings number not updating on member profile #4130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Oanh-and-only-Oanh opened this issue Mar 23, 2020 · 11 comments · May be fixed by #4193
Closed

Ratings number not updating on member profile #4130

Oanh-and-only-Oanh opened this issue Mar 23, 2020 · 11 comments · May be fixed by #4193
Labels
Member Profiles P1 Urgent (resolve within 24 hours) Rating

Comments

@Oanh-and-only-Oanh
Copy link

Issue: the rating number for Code is not updating after a dev challenge even though the graph updated.

Expected behavior: the rating number should update appropriately after dev challenges as well as the cooresponding graph

To reproduce

  1. Go to: https://www.topcoder.com/members/birdofpreyru/details/?track=DEVELOP&subTrack=CODE
  2. see rating in yellow read 1664 but graph reads 1809
  3. rating number and graph do not match
@adroc-tc
Copy link

@Oanh-and-only-Oanh checking in on this issue - is there a date to tackle this issue?

@Oanh-and-only-Oanh
Copy link
Author

@adroc-tc, we'll try to tackle this next week.

@skyhit
Copy link
Contributor

skyhit commented Apr 4, 2020

@Oanh-and-only-Oanh , the main reason is the data is retrieved from different backend apis.

  1. 1664 is from api call https://api.topcoder.com/v3/members/birdofpreyru/stats
  2. while 1809 is getting from https://api.topcoder.com/v3/members/birdofpreyru/stats/history

so here are two solutions.

  1. update the UI to use just the last rating of last challenge from Integrate with accounts-app for authentication #2.
  2. we need to research into the v3 member apis.

which do you prefer?

@Oanh-and-only-Oanh
Copy link
Author

@skyhit,

Please go with solution #1. "update the UI to use just the last rating of last challenge from #2."

@harshitmehta15
Copy link

harshitmehta15 commented Apr 6, 2020

Hey @Oanh-and-only-Oanh @skyhit there is a bigger issue here, I think the loader is not updating stats in Dynamo properly.

Take a look at tourist

So tourist's rating should be - from (history)
{"challengeId":17900,"challengeName":"SRM 782","date":"2020-03-28T00:00:00.000Z","rating":3751.0,"placement":1,"percentile":99.9552

Howver in stats
DATA_SCIENCE":{"challenges":603,"wins":35,"mostRecentEventName":"SRM 774","mostRecentEventDate":"2020-01-11T00:00:00.000Z","mostRecentSubmission":"2019-12-11T13:00:12.921Z"

SRM 774 to SRM 782 the stats are not getting updated correctly.

Please check the loaders.
cc: @adroc-tc

@Oanh-and-only-Oanh
Copy link
Author

@SathyaJayabal, can you check to see if this is still an issue in PROD?

@SathyaJayabal
Copy link
Collaborator

@Oanh-and-only-Oanh , this issue is fixed on production
Screenshot 2020-04-14 at 9 59 38 PM

@Oanh-and-only-Oanh
Copy link
Author

Oanh-and-only-Oanh commented Oct 27, 2020

@SathyaJayabal @luizrrodrigues this issue is back again in PROD.

  1. The Dynamo Tables are perfectly correct ✅ - No issue with loader of DW to Dynamo
  2. @at (upbeat) ran ES update on one of the users and the ratings are fixed for him on the site
  3. @at (upbeat) is working on rerunning the ES magic script to fix this. But ratings are updated almost everyhour, will we have to do manual run of those updates everytime?
    It took 2 days to complete that last time. Is there any other way?

@Oanh-and-only-Oanh Oanh-and-only-Oanh added P1 Urgent (resolve within 24 hours) and removed Code Review Passed labels Oct 27, 2020
@luizrrodrigues
Copy link
Collaborator

@Oanh-and-only-Oanh This is FE issue, looks like not getting latest challenge from track.

@luizrrodrigues
Copy link
Collaborator

@Oanh-and-only-Oanh Like discuss in Slack, after a deeper check, this issue coming from /v3/members/wleite/stats API, returned data pointing latest event in March, but in /v3/members/wleite/stats/history

/stats: https://api.topcoder.com/v3/members/wleite/stats
image

/history: https://api.topcoder.com/v3/members/wleite/stats/history
image

@SathyaJayabal
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Member Profiles P1 Urgent (resolve within 24 hours) Rating
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants