Skip to content

remove Notifications Settings link #4141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
SathyaJayabal opened this issue Mar 26, 2020 · 11 comments
Closed

remove Notifications Settings link #4141

SathyaJayabal opened this issue Mar 26, 2020 · 11 comments
Assignees
@luizrrodrigues
Labels
Notifications Prod Env Environment QA Pass
Milestone
v0.27.0

Comments

@SathyaJayabal
Copy link
Collaborator

Hide notifications settings link until settings page is ready
@SathyaJayabal
Copy link
Collaborator Author

The notification settings button and related text must be removed from the notification popup empty state.
Topcoder Challenges 2020-03-26 17-11-40

@SathyaJayabal SathyaJayabal added Beta Env Environment QA Fail QA verification on Dev has failed. Assignee to redo the fix. labels Mar 26, 2020
@SathyaJayabal
Copy link
Collaborator Author

@luizrrodrigues , need to remove the settings icon from the mobile view too
Screenshot 2020-03-26 at 6 53 45 PM

@SathyaJayabal SathyaJayabal removed the QA Fail QA verification on Dev has failed. Assignee to redo the fix. label Mar 26, 2020
@Oanh-and-only-Oanh
Copy link

Update text to "check your notification settings"

luizrrodrigues referenced this issue in topcoder-platform/navigation-component Mar 26, 2020
@luizrrodrigues
Remove 'Settings' link from empty panel and mobile view
ef56b4e
@luizrrodrigues
Copy link
Collaborator

@SathyaJayabal Done.

@SathyaJayabal
Copy link
Collaborator Author

SathyaJayabal commented Mar 27, 2020 •
edited
Loading

@Oanh-and-only-Oanh @luizrrodrigues , I am sorry there was some misunderstanding. This is the text I was talking about.(not the text on the button)
Screenshot 2020-03-27 at 8 07 27 AM

We need to hide the button and also hide this text as it refers to the settings.

@luizrrodrigues
Copy link
Collaborator

@SathyaJayabal Ah okay, so keep Notification Settings in button and hide both, button and text bellow.

Right?

@SathyaJayabal
Copy link
Collaborator Author

SathyaJayabal commented Mar 27, 2020 •
edited
Loading

@luizrrodrigues , yes right.

luizrrodrigues referenced this issue in topcoder-platform/navigation-component Mar 28, 2020
@luizrrodrigues
#4141: Updated button text and hide description
d5ccb2e
@luizrrodrigues
Copy link
Collaborator

@SathyaJayabal Fixed and deployed in Beta server.

@SathyaJayabal
Copy link
Collaborator Author

@luizrrodrigues , verified on beta
Screenshot 2020-03-29 at 9 52 19 AM

@SathyaJayabal SathyaJayabal mentioned this issue Mar 30, 2020
Closed
@SathyaJayabal SathyaJayabal added this to the v0.27.0 milestone Mar 30, 2020
@SathyaJayabal
Copy link
Collaborator Author

verified on beta (develop branch). Settings link and icon removed.
Screenshot 2020-03-30 at 1 47 10 PM

Screenshot 2020-03-30 at 1 46 07 PM

@SathyaJayabal SathyaJayabal added Prod Env Environment and removed Beta Env Environment labels Mar 30, 2020
@SathyaJayabal
Copy link
Collaborator Author

verified on prod
Screenshot 2020-03-30 at 5 42 46 PM
Screenshot 2020-03-30 at 5 43 03 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@luizrrodrigues luizrrodrigues

Labels
Notifications Prod Env Environment QA Pass
Projects
None yet
Milestone
v0.27.0
Development

No branches or pull requests
3 participants
@luizrrodrigues @Oanh-and-only-Oanh @SathyaJayabal