Skip to content

[$100] Prod - Active Gig Workers #631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jmgasper opened this issue Jun 4, 2021 · 8 comments
Closed

[$100] Prod - Active Gig Workers #631

jmgasper opened this issue Jun 4, 2021 · 8 comments

Comments

@jmgasper
Copy link
Collaborator

jmgasper commented Jun 4, 2021

@atelomycterus - Topcoder admins are saying that they aren't adding folks to the Active Gig Workers group, but it's still growing at a rapid rate. This was a custom role we added - it's not synced from the Topcoder side (group type = member, not Topcoder). Are there any reasons why folks may be getting automatically added to that group? Any way we can pull logs or something to figure that out?

Thanks!

Screen_Shot_2021-06-05_at_7_53_13_am

@jmgasper
Copy link
Collaborator Author

jmgasper commented Jun 4, 2021

Challenge https://www.topcoder.com/challenges/8b481f60-069d-462b-ac6f-b9a0df18181e has been created for this ticket.

This is an automated message for ghostar via Topcoder X

@jmgasper
Copy link
Collaborator Author

jmgasper commented Jun 4, 2021

Challenge https://www.topcoder.com/challenges/8b481f60-069d-462b-ac6f-b9a0df18181e has been assigned to obog.

This is an automated message for ghostar via Topcoder X

@atelomycterus
Copy link
Collaborator

@jmgasper I can reproduce it. I'll fix a challenge forum processor.
I'll look at a few more columns in the database and we can probably figure out which accounts were created this way.

How reproduce it
Create a new account, don't navigate to Topcoder Forums and register for a challenge:

image

@atelomycterus
Copy link
Collaborator

@jmgasper The 'Vanilla Member' role (type='member') is only added by default + Topcoder roles (type='topcoder') if user hasn't been created in Vanilla.

PR- topcoder-platform/challenge-forum-processor#61. Thanks!

You can change DEFAULT_MEMBER_ROLES if you want. The default value is ['Vanilla Member'] (array of Vanilla role names).

https://github.com/topcoder-platform/challenge-forum-processor/blob/893d5b13186b34f966183b43e52a3f9da3561576/src/constants.js#L63

 VANILLA: {
    DEFAULT_MEMBER_ROLES: ['Vanilla Member'],

}

Testing

Create a role (type='member') in Vanilla. Create a new user using topocder-dev.com and register for a challenge.
Verify roles for a new user in Vanilla.

Additional Notes

If you plan to create new users using Vanilla REST API/ other Vanilla methods (social connection/invitation, etc). Please verify it in DEV firstly. While analyzing the code, I noticed that in some cases, if a list of roles was not specified during inserting an user, all roles with the 'member' type will be assigned to the user. May cause unexpected behavior or grant more permissions than expected.

@jmgasper
Copy link
Collaborator Author

jmgasper commented Jun 5, 2021

Payment task has been updated: https://www.topcoder.com/challenges/8b481f60-069d-462b-ac6f-b9a0df18181e
Payments Complete
Winner: obog
Copilot: ghostar
Challenge 8b481f60-069d-462b-ac6f-b9a0df18181e has been paid and closed.

This is an automated message for ghostar via Topcoder X

@sdgun
Copy link
Collaborator

sdgun commented Jun 7, 2021

@atelomycterus @jmgasper FYI Created a new user in Dev to verify this issue(user handle - testvffortc) but this user cannot register to any challenge, looks like there are issues with the new users. I am checking this with @drasticdpk I will verify once this is fixed.

@sdgun
Copy link
Collaborator

sdgun commented Jun 8, 2021

Verified in Dev.

  1. Created role (type='member') in Vanilla from vanilla app UI
  2. Created a new user using topocder-dev.com and registered to a challenge.
  3. Verified the roles for the new user in Vanilla

Observation: Active gig workers role is not added

image

@sdgun
Copy link
Collaborator

sdgun commented Jun 9, 2021

Keeping since this cannot be directly tested in production.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants