Merge pull request #249 from topcoder-platform/develop

Release 2020-09-08

Author: sushilshinde

Diff for: package.json

@@ -31,7 +31,7 @@
     "lint:js": "./node_modules/.bin/eslint --ext .js,.jsx .",
     "test": "npm run lint && npm run jest"
   },
-  "version": "1.0.3",
+  "version": "1.0.4",
   "dependencies": {
     "auth0-js": "^6.8.4",
     "config": "^3.2.0",

Diff for: src/services/challenges.js

@@ -590,7 +590,7 @@ class ChallengesService {
     const roleId = await this.getRoleId('Submitter');
     const params = {
       challengeId,
-      memberHandle: user.handle,
+      memberHandle: encodeURIComponent(user.handle),
       roleId,
     };
     const res = await this.private.apiV5.postJson('/resources', params);
@@ -608,7 +608,7 @@ class ChallengesService {
     const roleId = await this.getRoleId('Submitter');
     const params = {
       challengeId,
-      memberHandle: user.handle,
+      memberHandle: encodeURIComponent(user.handle),
       roleId,
     };
     const res = await this.private.apiV5.delete('/resources', JSON.stringify(params));

Diff for: src/services/terms.js

@@ -31,18 +31,14 @@ class TermsService {
    * @return {Promise}       promise of the request result
    */
   async getChallengeTerms(terms) {
-    if (this.private.tokenV3) {
-      const challengeService = getChallengeService(this.private.tokenV3);
-      const roleId = await challengeService.getRoleId('Submitter');
-      const registerTerms = _.filter(terms, t => t.roleId === roleId);
-
-      return Promise.all(_.map(registerTerms, term => this.getTermDetails(term.id)))
-        .then(challengeTerms => (
-          _.map(challengeTerms, term => _.pick(term, 'id', 'title', 'agreed'))
-        ));
-    }
-
-    return [];
+    const challengeService = getChallengeService(this.private.tokenV3);
+    const roleId = await challengeService.getRoleId('Submitter');
+    const registerTerms = _.filter(terms, t => t.roleId === roleId);
+
+    return Promise.all(_.map(registerTerms, term => this.getTermDetails(term.id)))
+      .then(challengeTerms => (
+        _.map(challengeTerms, term => _.pick(term, 'id', 'title', 'agreed'))
+      ));
   }
 
   /**