Skip to content

Commit eb79a5b

Browse files
Merge pull request #252 from topcoder-platform/milestone-20200917
Fix Public Profile: Past MARATHON MATCH challenges are not shown
2 parents 19dc91d + b4d6c36 commit eb79a5b

File tree

4 files changed

+15
-11
lines changed

4 files changed

+15
-11
lines changed

Diff for: .circleci/config.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ jobs:
2828
- attach_workspace:
2929
at: .
3030
- run: echo "//registry.npmjs.org/:_authToken=$NPM_TOKEN" >> ~/.npmrc
31-
- run: npm publish
31+
- run: npm publish --tag test-release
3232
# dont change anything
3333
workflows:
3434
version: 2

Diff for: package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@
3131
"lint:js": "./node_modules/.bin/eslint --ext .js,.jsx .",
3232
"test": "npm run lint && npm run jest"
3333
},
34-
"version": "1.0.4",
34+
"version": "1000.22.6",
3535
"dependencies": {
3636
"auth0-js": "^6.8.4",
3737
"config": "^3.2.0",

Diff for: src/actions/members.js

+9-7
Original file line numberDiff line numberDiff line change
@@ -331,27 +331,29 @@ async function getUserMarathonInit(handle, uuid) {
331331
* @desc Create an action that loads the member marathon.
332332
* @param {String} uuid Operation UUID.
333333
* @param {String} handle Member handle.
334+
* @param {String} memberId Member id.
334335
* @param {String} tokenV3 v3 auth token.
335336
* @param {Number} start page.
336337
* @param {Number} page size.
337338
* @param {Boolean} whether to refresh.
338339
* @return {Action}
339340
*/
340341
async function getUserMarathonDone(
341-
uuid, handle, tokenV3, pageNum, pageSize,
342+
uuid, handle, memberId, tokenV3, pageNum, pageSize,
342343
refresh,
343344
) {
344-
const filter = { status: 'PAST', isRatedForMM: 'true' };
345+
const filter = { status: 'Completed' };
345346
const params = {};
346-
params.orderBy = 'endDate desc';
347-
params.limit = pageSize;
348-
params.offset = pageNum * pageSize;
347+
params.sortBy = 'endDate';
348+
params.sortOrder = 'desc';
349+
params.perPage = pageSize;
350+
params.page = pageNum;
349351

350352
const service = getChallengesService(tokenV3);
351-
return service.getUserMarathonMatches(handle, filter, params)
353+
return service.getUserMarathonMatches(memberId, filter, params)
352354
.then(res => ({
353355
uuid,
354-
marathons: res,
356+
marathons: { challenges: res },
355357
refresh,
356358
handle,
357359
}));

Diff for: src/services/challenges.js

+4-2
Original file line numberDiff line numberDiff line change
@@ -534,18 +534,20 @@ class ChallengesService {
534534
/**
535535
* Gets marathon matches of the specified user.
536536
* @param {String} memberId User whose challenges we want to fetch.
537+
* @param {Object} filter
537538
* @param {Object} params
538539
* @return {Promise} Resolves to the api response.
539540
*/
540-
async getUserMarathonMatches(memberId, params) {
541+
async getUserMarathonMatches(memberId, filter, params) {
541542
const newParams = {
543+
...filter,
542544
...params,
543545
tag: 'Marathon Match',
544546
memberId,
545547
};
546548

547549
const res = await this.private.apiV5.get(`/challenges?${qs.stringify(newParams)}`);
548-
return getApiResponsePayload(res);
550+
return res.json();
549551
}
550552

551553
/**

0 commit comments

Comments
 (0)