Skip to content

Commit ebb0f8e

Browse files
authored
Merge pull request #219 from topcoder-platform/issue-4739
Fix Open For Review changes filter
2 parents 4b5f5f3 + 477ccfe commit ebb0f8e

File tree

3 files changed

+45
-9
lines changed

3 files changed

+45
-9
lines changed

__tests__/__snapshots__/index.js.snap

+10
Original file line numberDiff line numberDiff line change
@@ -377,6 +377,16 @@ Object {
377377
"DEVELOP": "Development",
378378
"QA": "Quality Assurance",
379379
},
380+
"OLD_COMPETITION_TRACKS": Object {
381+
"DATA_SCIENCE": "DATA_SCIENCE",
382+
"DESIGN": "DESIGN",
383+
"DEVELOP": "DEVELOP",
384+
"QA": "QA",
385+
},
386+
"OLD_SUBTRACKS": Object {
387+
"BUG_HUNT": "BUG_HUNT",
388+
"TEST_SUITES": "TEST_SUITES",
389+
},
380390
"REVIEW_OPPORTUNITY_TYPES": Object {
381391
"Contest Review": "Review",
382392
"Iterative Review": "Iterative Review",

src/services/reviewOpportunities.js

+23-9
Original file line numberDiff line numberDiff line change
@@ -4,23 +4,37 @@
44
* submitting applications.
55
*/
66
import _ from 'lodash';
7+
import { COMPETITION_TRACKS, OLD_COMPETITION_TRACKS, OLD_SUBTRACKS } from 'utils/tc';
78
import { getApi } from './api';
89

910
/**
1011
* Sync the fields of V3 and V5 for front-end to process successfully
11-
* @param challenges - challenges to normalize
12+
* @param opportunities - opportunities to normalize
1213
*/
13-
export function normalizeChallenges(challenges) {
14-
if (challenges) {
15-
_.map(challenges, (ch) => {
16-
const { challenge } = ch;
17-
if (challenge.technologies && challenge.technologies.includes('Data Science')) {
18-
challenge.track = 'DATA_SCIENCE';
14+
export function normalizeChallenges(opportunities) {
15+
if (opportunities) {
16+
/* Issue#4739 : Temporary add track to review opportunities challenges
17+
* until receive API V5 update. */
18+
_.map(opportunities, (opportunity) => {
19+
const { challenge } = opportunity;
20+
challenge.track = COMPETITION_TRACKS.DEVELOP;
21+
if (challenge.technologies) {
22+
if (challenge.technologies.includes(COMPETITION_TRACKS.DATA_SCIENCE)) {
23+
challenge.track = COMPETITION_TRACKS.DATA_SCIENCE;
24+
} else if (challenge.technologies.includes(OLD_COMPETITION_TRACKS.QA)) {
25+
challenge.track = COMPETITION_TRACKS.QA;
26+
}
27+
} else if (challenge.subTrack === OLD_SUBTRACKS.TEST_SUITES
28+
|| challenge.subTrack === OLD_SUBTRACKS.BUG_HUNT) {
29+
challenge.track = COMPETITION_TRACKS.QA;
30+
} else if (challenge.track === OLD_COMPETITION_TRACKS.DESIGN) {
31+
challenge.track = COMPETITION_TRACKS.DESIGN;
1932
}
20-
return _.defaults(ch, { challenge });
33+
return _.defaults(opportunity, { challenge });
2134
});
2235
}
23-
return challenges;
36+
37+
return opportunities;
2438
}
2539

2640
/**

src/utils/tc.js

+12
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,18 @@ export const COMPETITION_TRACKS = {
1717
QA: 'Quality Assurance',
1818
};
1919

20+
export const OLD_COMPETITION_TRACKS = {
21+
DATA_SCIENCE: 'DATA_SCIENCE',
22+
DESIGN: 'DESIGN',
23+
DEVELOP: 'DEVELOP',
24+
QA: 'QA',
25+
};
26+
27+
export const OLD_SUBTRACKS = {
28+
TEST_SUITES: 'TEST_SUITES',
29+
BUG_HUNT: 'BUG_HUNT',
30+
};
31+
2032
/**
2133
* Review Opportunity types
2234
*/

0 commit comments

Comments
 (0)