Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validating ProForma #19

Open
acesnik opened this issue Feb 6, 2018 · 2 comments
Open

Validating ProForma #19

acesnik opened this issue Feb 6, 2018 · 2 comments

Comments

@acesnik
Copy link
Contributor

acesnik commented Feb 6, 2018

No description provided.

@acesnik
Copy link
Contributor Author

acesnik commented Feb 27, 2018

  1. Check for legal syntax
  2. Check that the syntax is logically correct (e.g. prefix tag should not be used with other keys in the sequence)

@acesnik
Copy link
Contributor Author

acesnik commented Sep 10, 2018

It looks like this is actually pretty polished up to the parsing of ProteoformGroup objects. What's next?

  • We're not validating the modification sites... should we check to see that the amino acid target makes sense for the modification?
  • Should we create a ProteoformFactory, that can generate possible proteoforms given a proteoform group? This would allow us to consider the ambiguity descriptors.

@acesnik acesnik added this to the ProForma 2.0 milestone Sep 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant