Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

antigen update is skipped when antigen selfupdate failed #22

Closed
xyz1001 opened this issue Oct 17, 2022 · 3 comments · Fixed by #39
Closed

antigen update is skipped when antigen selfupdate failed #22

xyz1001 opened this issue Oct 17, 2022 · 3 comments · Fixed by #39

Comments

@xyz1001
Copy link
Contributor

xyz1001 commented Oct 17, 2022 •
edited
Loading

See r-darwish/topgrade issue for details.
@s34m s34m linked a pull request Oct 19, 2022 that will close this issue
Fixes antigen update, Issue #22 #38
Closed
5 tasks
@s34m s34m removed a link to a pull request Oct 19, 2022
Fixes antigen update, Issue #22 #38
Closed
5 tasks
@s34m s34m linked a pull request Oct 19, 2022 that will close this issue
Fixes antigen update #39
Merged
7 tasks
@s34m
Copy link
Member

s34m commented Oct 19, 2022

Could you try out if this branch works for you? https://github.com/DottoDev/topgrade-dev/tree/fixes-antigen

@xyz1001
Copy link
Contributor Author

xyz1001 commented Oct 20, 2022

It seems that the left parenthesis is wrong. It should be

let cmd = format!("source {} && (antigen selfupdate ; antigen update)", zshrc.display());

@s34m
Copy link
Member

s34m commented Oct 20, 2022

Thank you, will merge the corrected PR

@xyz1001 xyz1001 closed this as completed Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes antigen update s34m/topgrade-dev
2 participants
@xyz1001 @s34m