Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/update-modules-unload-reload #977

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Feature/update-modules-unload-reload #977

wants to merge 6 commits into from

Conversation

niStee
Copy link
Contributor

@niStee niStee commented Nov 2, 2024

What does this PR do

Standards checklist

  • The PR title is descriptive
  • I have read CONTRIBUTING.md
  • Optional: I have tested the code myself
  • If this PR introduces new user-facing messages they are translated

For new steps

  • Optional: Topgrade skips this step where needed
  • Optional: The --dry-run option works with this step
  • Optional: The --yes option works with this step if it is supported by
    the underlying command

If you developed a feature or a bug fix for someone else and you do not have the
means to test it, please tag this person here.

@niStee niStee mentioned this pull request Nov 2, 2024
Open
6 tasks
@niStee niStee marked this pull request as ready for review November 2, 2024 15:18
@SteveLauC SteveLauC linked an issue Nov 3, 2024 that may be closed by this pull request
topgrade cannot upgrade some powershell modules because they are in use #972
Open
6 tasks
@SteveLauC
Copy link
Member

@soredake, is there anyway you can give this a test?

@soredake
Copy link

soredake commented Nov 3, 2024

@SteveLauC I don't think I can do this without ready-to-use binaries.

@SteveLauC
Copy link
Member

SteveLauC commented Nov 4, 2024 •
edited
Loading

@niStee, mind uploading a binary with this patch so that we can have this patch tested?

You can do it in your fork, ref: https://github.com/SteveLauC/topgrade/releases

Tip: you can disable the GitHub Action in your fork before drafting a new release: https://github.com/SteveLauC/topgrade/settings/actions

Screenshot 2024-11-04 at 10 01 30 AM

@niStee
Copy link
Contributor Author

niStee commented Nov 9, 2024 •
edited
Loading

@niStee, mind uploading a binary with this patch so that we can have this patch tested?

You can do it in your fork, ref: https://github.com/SteveLauC/topgrade/releases

Tip: you can disable the GitHub Action in your fork before drafting a new release: https://github.com/SteveLauC/topgrade/settings/actions
Screenshot 2024-11-04 at 10 01 30 AM

like this: https://github.com/niStee/topgrade/releases/tag/16.0.2 ?

@soredake
Copy link

soredake commented Nov 9, 2024 •
edited
Loading

Unfortunately, this pr does not fix my problem, here is a log:
update-modules-unload-reload-pr-log.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SteveLauC SteveLauC SteveLauC left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

topgrade cannot upgrade some powershell modules because they are in use
3 participants
@niStee @SteveLauC @soredake