feat: support setting defaults #802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noahnu
approved these changes
Sep 1, 2023
tophat-opensource-bot
pushed a commit
that referenced
this pull request
Sep 1, 2023
# [4.5.0](v4.4.0...v4.5.0) (2023-09-01) ### Features * support setting defaults ([#802](#802)) ([c877559](c877559))
|
🎉 This PR is included in version 4.5.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
@all-contributors add @michaljelonek for code |
|
I've put up a pull request to add @michaljelonek! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
with_defaultsthat allows settinginclude,exclude,matcherandextension_classuse_extensionto usewith_defaults, functionally unchangedRelated Issues
Closes #800, subsequent asserts seem to ignore the matcher.
Checklist
Additional Comments
Unsure what extra tests to add, but it seems like there would be benefit in more. Coverage seems to be at the same percentage.