Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client does not take proxy errors into account #5

Open
hielkehoeve opened this issue Jan 27, 2022 · 0 comments
Open

Client does not take proxy errors into account #5

hielkehoeve opened this issue Jan 27, 2022 · 0 comments
Labels
bug Something isn't working patch Create a patch release after merging

Comments

@hielkehoeve
Copy link
Contributor

The client always assumes it will get an ErrorReport from KeyHub when an error occurs:
eg: https://github.com/topicuskeyhub/go-keyhub/blob/master/groups.go#L85

This will only work if all possible situations will return an error response in this json format. When a proxy returns a gateway timout or the webserver is (re)starting the error response will not match the json format and a json unmarshall error will occur, losing all useful information about what went wrong.

@hielkehoeve hielkehoeve added bug Something isn't working patch Create a patch release after merging labels Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working patch Create a patch release after merging
Projects
None yet
Development

No branches or pull requests

1 participant