Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24201] failing to update Magisk #5544

Closed
madduck opened this issue Mar 5, 2022 · 7 comments
Closed

[24201] failing to update Magisk #5544

madduck opened this issue Mar 5, 2022 · 7 comments
Assignees
Labels
regression Something works in previous versions but not in the current one

Comments

@madduck
Copy link

madduck commented Mar 5, 2022

I just installed 24201 (Canary) in the hope of addressing/resolving https://github.com/topjohnwu/Magisk/issues/4174[](https://user-images.githubusercontent.com/195073/156877079-04268fd7-d1e7-4985-98cf-c69bd47b45a7.png). When launching, I am now shown that Magisk is installed, although the app itself still has a N/A next to the latest version:
image
I was asked at first launch whether to update. However, when I confirmed, as well as if I click that Update button now, select to patch vbmeta in boot.img (which I used to have to do), and then choose the Direct Installation method, the install fails:

! Installation failed
! Unable to detect target image

The problem persists if I try without "vbmeta in boot".

The patch method does seem to work, however.

Device: Oneplus 5T
Android version: 11
Magisk version name: canary
Magisk version code: 24201

@rootk1t
Copy link

rootk1t commented Mar 7, 2022

I faced the same issue with Magisk v24.2

Magisk App updated without issues to v24.2.

  1. When i click update as in screenshot above, it stopps with error
    ! Installation failed
    ! Unable to detect target image
  2. I entered TWRP 3.6.0, tried installing Magisk-v24.2.apk (with and without renaming to .zip).
    It says:

Magisk 24.2 Installer
! Cannot mount /system

  • Unmounting partitions

Update process ended with ERROR: 1
Error installing zip file "path/Magisk-v24.2.zip"

  1. I tried to patch boot.img within Magisk App. It patches it without issues, but after flashing it via TWRP, Magisk Manager asks to perform some additional setup when opened, and reboot.
    After reboot is asks the same again and again.

The same happens to the latest canary as well.

At the same time Magisk-v24.1.apk installs without issues within Android or TWRP.

Device: Sony Tablet Z
Android version: 9.0
Magisk version name: canary
Magisk version code: 24200

@canyie
Copy link
Collaborator

canyie commented Mar 7, 2022

app-debug.zip
How about this? Reverted #5524 .

@rootk1t
Copy link

rootk1t commented Mar 7, 2022

Thank you for your build.

Unfortunately it didn't work for me.

As official v24.2 it stopps with an error in Magisk Manager:
"! Installation failed
! Unable to detect target image"

And from TWRP it shows

"! Cannot mount /system

Unmounting partitions

Update process ended with ERROR: 1
Error installing zip file "path/app-debug.zip"

@BlueMax
Copy link

BlueMax commented Mar 13, 2022

As official v24.2 it stopps with an error in Magisk Manager: "! Installation failed ! Unable to detect target image"

Are you sure you haven't accidentally pointed the app-debug.zip to it (instead of boot.img)? I once did and i think it was the same error.

And from TWRP it shows
Update process ended with ERROR: 1 Error installing zip file "path/app-debug.zip"

I get the same on TWRP 3.6.1 with Magisk 24.3 so something seems to be still wrong there.
I updated to v24.3 manager first, pre-patched the boot.img and flashed it with dd in TWRP. That worked for me (I9506, Linux 3.4, LOS18.1).

@canyie
Copy link
Collaborator

canyie commented Mar 17, 2022

Have you installed magisk alpha? Revert to official version and try again.

@yujincheng08 yujincheng08 added the regression Something works in previous versions but not in the current one label Mar 19, 2022
@yujincheng08
Copy link
Collaborator

Duplicate of #5530

@yujincheng08 yujincheng08 marked this as a duplicate of #5530 Mar 19, 2022
@yujincheng08
Copy link
Collaborator

Try #5620

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression Something works in previous versions but not in the current one
Projects
None yet
Development

No branches or pull requests

5 participants