This repository has been archived by the owner on Oct 31, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Freyskeyd
force-pushed
the
feature/tp-853
branch
from
February 19, 2024 13:20
256f48d
to
ac1916d
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #459 +/- ##
==========================================
- Coverage 71.43% 71.25% -0.18%
==========================================
Files 223 226 +3
Lines 12404 12438 +34
==========================================
+ Hits 8861 8863 +2
- Misses 3543 3575 +32 ☔ View full report in Codecov by Sentry. |
Freyskeyd
force-pushed
the
feature/tp-853
branch
8 times, most recently
from
February 19, 2024 15:04
fe37e3f
to
dc2454f
Compare
It would be good to have a sibling PR for the topos-playground as a sort of test that everything works as expected after this lands. |
This PR is backward compatible with the current CLI command. I think you mean updating the |
Yeah, I think that's what I meant! :) I was thinking about how the topos-playground exercises the whole stack, but you're right, it's the local-erc20 image that is relevant here. |
dvdplm
approved these changes
Feb 20, 2024
dvdplm
approved these changes
Feb 21, 2024
Freyskeyd
force-pushed
the
feature/tp-853
branch
from
February 27, 2024 10:18
dfb0914
to
b6fce4a
Compare
Signed-off-by: Simon Paitrault <simon.paitrault@gmail.com>
Signed-off-by: Simon Paitrault <simon.paitrault@gmail.com>
Freyskeyd
force-pushed
the
feature/tp-853
branch
from
February 29, 2024 15:15
b6fce4a
to
6713886
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a dedicated crate for the
topos
runtime, decoupled from thetopos
CLI that can be used by node operator.The purpose of the
topos-node
crate is to have everything to run a node from a config file.This PR is just moving things around and the topos CLI should keep working as expected.
The
topos node up
command is going to be deprecated, the replacement being thetopos-node
binary.PR Checklist: