Skip to content
This repository has been archived by the owner on Oct 31, 2024. It is now read-only.

feat: introduce topos-node crate #459

Merged
merged 2 commits into from
Mar 1, 2024
Merged

feat: introduce topos-node crate #459

merged 2 commits into from
Mar 1, 2024

Conversation

Freyskeyd
Copy link
Member

Description

This PR introduces a dedicated crate for the topos runtime, decoupled from the topos CLI that can be used by node operator.
The purpose of the topos-node crate is to have everything to run a node from a config file.

This PR is just moving things around and the topos CLI should keep working as expected.
The topos node up command is going to be deprecated, the replacement being the topos-node binary.

PR Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added or updated tests that comprehensively prove my change is effective or that my feature works

@Freyskeyd Freyskeyd requested a review from a team as a code owner February 16, 2024 15:37
@Freyskeyd Freyskeyd requested review from dvdplm and gruberb February 16, 2024 15:37
Copy link

codecov bot commented Feb 19, 2024

Codecov Report

Attention: Patch coverage is 78.28571% with 38 lines in your changes are missing coverage. Please review.

Project coverage is 71.25%. Comparing base (c41a51a) to head (6713886).

Files Patch % Lines
crates/topos-node/src/lib.rs 77.24% 33 Missing ⚠️
crates/topos-node/src/main.rs 0.00% 3 Missing ⚠️
crates/topos-node/build.rs 86.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #459      +/-   ##
==========================================
- Coverage   71.43%   71.25%   -0.18%     
==========================================
  Files         223      226       +3     
  Lines       12404    12438      +34     
==========================================
+ Hits         8861     8863       +2     
- Misses       3543     3575      +32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Freyskeyd Freyskeyd force-pushed the feature/tp-853 branch 8 times, most recently from fe37e3f to dc2454f Compare February 19, 2024 15:04
@dvdplm
Copy link
Contributor

dvdplm commented Feb 20, 2024

It would be good to have a sibling PR for the topos-playground as a sort of test that everything works as expected after this lands.

@Freyskeyd
Copy link
Member Author

This PR is backward compatible with the current CLI command. I think you mean updating the local-erc20 right?

@dvdplm
Copy link
Contributor

dvdplm commented Feb 20, 2024

I think you mean updating the local-erc20 right?

Yeah, I think that's what I meant! :)

I was thinking about how the topos-playground exercises the whole stack, but you're right, it's the local-erc20 image that is relevant here.

crates/topos-node/Cargo.toml Show resolved Hide resolved
crates/topos-node/build.rs Outdated Show resolved Hide resolved
crates/topos-node/src/lib.rs Show resolved Hide resolved
crates/topos-node/src/lib.rs Show resolved Hide resolved
crates/topos-node/src/lib.rs Show resolved Hide resolved
crates/topos-node/src/main.rs Show resolved Hide resolved
crates/topos/tests/config.rs Outdated Show resolved Hide resolved
crates/topos/tests/config.rs Outdated Show resolved Hide resolved
Signed-off-by: Simon Paitrault <simon.paitrault@gmail.com>
Signed-off-by: Simon Paitrault <simon.paitrault@gmail.com>
@Freyskeyd Freyskeyd merged commit d8db631 into main Mar 1, 2024
21 checks passed
@Freyskeyd Freyskeyd deleted the feature/tp-853 branch March 1, 2024 20:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants