You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
When filing a PR, i got to the stage of PR review and only realized then that while working on the PR, i messed up source code formatting. THis means now tedious fixing of the PR. Ideally, I would have been guided earlier in the process that i am deviating from the standard.
Describe the solution you'd like
Introduce stricter Linting Rules, following the linting strategy + rules the home assistant project itself uses.
I think that is a good roadmap. Let's tackle this once we get 3.8 with WB support out of the way. I'd also like to have some rules for the MD files (I've something ready there from work, I'll take that over). Especially, if we (as you rightfully said) add a documentation wiki or something like that.
Checklist
Is your feature request related to a problem? Please describe.
When filing a PR, i got to the stage of PR review and only realized then that while working on the PR, i messed up source code formatting. THis means now tedious fixing of the PR. Ideally, I would have been guided earlier in the process that i am deviating from the standard.
Describe the solution you'd like
Introduce stricter Linting Rules, following the linting strategy + rules the home assistant project itself uses.
Home Assistant uses:
THey follow the PEP8 + PEP257 Guidelines [source] (https://developers.home-assistant.io/docs/development_guidelines#our-recommendations)
I suggest to take over the Home Assistant's project configurations to assure adherence to the project's standards and best practices..
In detail this would mean:
Describe alternatives you've considered
In case strict linting shall not be enforced, the suggested standards could be mentioned in CONTRIBUTING.md
Additional context
In case you are fine with the suggested approach, i can work on a PR with the suggested changes.
Diagnostics dump
No response
The text was updated successfully, but these errors were encountered: