Skip to content

Commit 42968ce

Browse files
Test for all python versions
1 parent 1367c6c commit 42968ce

File tree

3 files changed

+15
-13
lines changed

3 files changed

+15
-13
lines changed

.github/workflows/tests.yaml

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,12 +9,15 @@ on:
99
jobs:
1010
unittests:
1111
runs-on: ubuntu-latest
12+
strategy:
13+
matrix:
14+
python-version: [3.6, 3.7, 3.8]
1215
steps:
13-
- uses: actions/checkout@v1
14-
- name: Set up Python 3.6
15-
uses: actions/setup-python@v1
16+
- uses: actions/checkout@v2
17+
- name: Set up Python ${{ matrix.python-version }}
18+
uses: actions/setup-python@v2
1619
with:
17-
python-version: 3.6
20+
python-version: ${{ matrix.python-version }}
1821
- name: Install dependencies
1922
run: |
2023
python -m pip install --upgrade pip

CHANGELOG.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,8 @@
1+
# 0.6.2
2+
3+
## Bug fix
4+
- Fix install with pip > 19
5+
16
# 0.6.1
27

38
## Bug fix

setup.py

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,8 @@
88
CUDA_HOME,
99
CppExtension,
1010
)
11-
HAS_TORCH=True
1211
except:
13-
HAS_TORCH=False
12+
raise ModuleNotFoundError("Please install pytorch >= 1.1 before proceeding.")
1413

1514
import glob
1615

@@ -21,8 +20,6 @@
2120

2221

2322
def get_ext_modules():
24-
if not HAS_TORCH:
25-
return []
2623
TORCH_MAJOR = int(torch.__version__.split(".")[0])
2724
TORCH_MINOR = int(torch.__version__.split(".")[1])
2825
extra_compile_args = ["-O3"]
@@ -57,15 +54,12 @@ def get_ext_modules():
5754
return ext_modules
5855

5956
def get_cmdclass():
60-
if HAS_TORCH:
61-
return {"build_ext": BuildExtension}
62-
else:
63-
return {}
57+
return {"build_ext": BuildExtension}
6458

6559
requirements = ["torch>=1.1.0"]
6660

6761
url = 'https://github.com/nicolas-chaulet/torch-points-kernels'
68-
__version__="0.6.1"
62+
__version__="0.6.2"
6963
setup(
7064
name="torch-points-kernels",
7165
version=__version__,

0 commit comments

Comments
 (0)